Skip to content

Commit

Permalink
Fix change events for custom elements (#22938)
Browse files Browse the repository at this point in the history
* Bypass react event system for custom elements

* Going to try fixing react event system instead

* finally got it to call onChange, but perhaps too many times

* update test

* Removed ReactDOMComponent changes, now works but still doubles for bubbles

* Maybe i should only support bubbling events

* removed some old stuff

* cleaned up changeeventplugin stuff

* prettier, lint

* removed changeeventplugin stuff

* remove unneeded gate for onInput test

* Go back to using ChangeEventPlugin

* Add input+change test

* lint

* Move logic to shouldUseChangeEvent

* use memoizedProps instead of pendingProps

* Run form control behavior before custom element behavior

* add bubbling test

* forgot to append container to body

* add child event target test

* expand <input is=...> test expectations

* Make tests more realistic

* Add extra test

* Add missing gating

* Actually fix gating

Co-authored-by: Dan Abramov <dan.abramov@me.com>
  • Loading branch information
josepharhar and gaearon authored Jan 19, 2022
1 parent d8cfeaf commit 05a55a4
Show file tree
Hide file tree
Showing 2 changed files with 591 additions and 1 deletion.
Loading

0 comments on commit 05a55a4

Please sign in to comment.