Skip to content

Commit

Permalink
Revert Build Versions from Content Hash to Commit Hash (#29663)
Browse files Browse the repository at this point in the history
#29236 caused issues for internal
syncs at Meta, because we were computing version numbers using file
hashes (to eliminate "no-op" internal sync commits). The problem is that
since version numbers may not be consistent across synced files (e.g. if
some files have not changed in recent commits), the newly introduced
version mismatch check fails.

There's some more work that needs to be done here to restore the
benefits of file-specific hashing, but for now this simply reverts the
content hash changes from the following PRs:

- #28633
(95319ab)
- #28590
(37676ab)
- #28582
(cb076b5)
- #26734
(5dd90c5)
- #26331
(3cad3a5)

DiffTrain build for [5bd4031](5bd4031)
  • Loading branch information
yungsters committed May 30, 2024
1 parent 4bebe8e commit 0727c8a
Show file tree
Hide file tree
Showing 32 changed files with 76 additions and 57 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
72644ef2f2ec7a274f79f6b32320d62757521329
5bd403122645ef0f0924ac5466f56e670a8f5b8d
1 change: 1 addition & 0 deletions compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5bd403122645ef0f0924ac5466f56e670a8f5b8d
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if (
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = '19.0.0-www-classic-f4a35977';
var ReactVersion = '19.0.0-www-classic-5bd4031226-20240530';

// Re-export dynamic flags from the www version.
var dynamicFeatureFlags = require('ReactFeatureFlags');
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if (
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = '19.0.0-www-modern-85c20051';
var ReactVersion = '19.0.0-www-modern-5bd4031226-20240530';

// Re-export dynamic flags from the www version.
var dynamicFeatureFlags = require('ReactFeatureFlags');
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -684,4 +684,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-abbf2e79";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -684,4 +684,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-abbf2e79";
exports.version = "19.0.0-www-modern-5bd4031226-20240530";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-d6ae41f2";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-d6ae41f2";
exports.version = "19.0.0-www-modern-5bd4031226-20240530";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = '19.0.0-www-classic-e2e1fbaf';
var ReactVersion = '19.0.0-www-classic-5bd4031226-20240530';

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = '19.0.0-www-modern-05c03f69';
var ReactVersion = '19.0.0-www-modern-5bd4031226-20240530';

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10640,7 +10640,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "19.0.0-www-classic-12951007",
version: "19.0.0-www-classic-5bd4031226-20240530",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1370 = {
Expand Down Expand Up @@ -10671,7 +10671,7 @@ var internals$jscomp$inline_1370 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-12951007"
reconcilerVersion: "19.0.0-www-classic-5bd4031226-20240530"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1371 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10115,7 +10115,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "19.0.0-www-modern-fc3d605e",
version: "19.0.0-www-modern-5bd4031226-20240530",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1356 = {
Expand Down Expand Up @@ -10146,7 +10146,7 @@ var internals$jscomp$inline_1356 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-fc3d605e"
reconcilerVersion: "19.0.0-www-modern-5bd4031226-20240530"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1357 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31059,7 +31059,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-www-classic-b0252694';
var ReactVersion = '19.0.0-www-classic-5bd4031226-20240530';

function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
implementation) {
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -30236,7 +30236,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-www-modern-4c2e3832';
var ReactVersion = '19.0.0-www-modern-5bd4031226-20240530';

function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
implementation) {
Expand Down
13 changes: 8 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17045,12 +17045,15 @@ function getCrossOriginStringAs(as, input) {
return "use-credentials" === input ? input : "";
}
var isomorphicReactPackageVersion$jscomp$inline_1753 = React.version;
if ("19.0.0-www-classic-8bdf4305" !== isomorphicReactPackageVersion$jscomp$inline_1753)
if (
"19.0.0-www-classic-5bd4031226-20240530" !==
isomorphicReactPackageVersion$jscomp$inline_1753
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1753,
"19.0.0-www-classic-8bdf4305"
"19.0.0-www-classic-5bd4031226-20240530"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17069,7 +17072,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1760 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-8bdf4305",
version: "19.0.0-www-classic-5bd4031226-20240530",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2204 = {
Expand Down Expand Up @@ -17099,7 +17102,7 @@ var internals$jscomp$inline_2204 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-8bdf4305"
reconcilerVersion: "19.0.0-www-classic-5bd4031226-20240530"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2205 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17603,4 +17606,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-8bdf4305";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
13 changes: 8 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16408,12 +16408,15 @@ function getCrossOriginStringAs(as, input) {
return "use-credentials" === input ? input : "";
}
var isomorphicReactPackageVersion$jscomp$inline_1724 = React.version;
if ("19.0.0-www-modern-cc8139fa" !== isomorphicReactPackageVersion$jscomp$inline_1724)
if (
"19.0.0-www-modern-5bd4031226-20240530" !==
isomorphicReactPackageVersion$jscomp$inline_1724
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1724,
"19.0.0-www-modern-cc8139fa"
"19.0.0-www-modern-5bd4031226-20240530"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -16432,7 +16435,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1726 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-cc8139fa",
version: "19.0.0-www-modern-5bd4031226-20240530",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2195 = {
Expand Down Expand Up @@ -16462,7 +16465,7 @@ var internals$jscomp$inline_2195 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-cc8139fa"
reconcilerVersion: "19.0.0-www-modern-5bd4031226-20240530"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2196 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16836,4 +16839,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-cc8139fa";
exports.version = "19.0.0-www-modern-5bd4031226-20240530";
13 changes: 8 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17814,12 +17814,15 @@ function getCrossOriginStringAs(as, input) {
return "use-credentials" === input ? input : "";
}
var isomorphicReactPackageVersion$jscomp$inline_1840 = React.version;
if ("19.0.0-www-classic-13942464" !== isomorphicReactPackageVersion$jscomp$inline_1840)
if (
"19.0.0-www-classic-5bd4031226-20240530" !==
isomorphicReactPackageVersion$jscomp$inline_1840
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1840,
"19.0.0-www-classic-13942464"
"19.0.0-www-classic-5bd4031226-20240530"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17838,7 +17841,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1847 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-13942464",
version: "19.0.0-www-classic-5bd4031226-20240530",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17882,7 +17885,7 @@ var devToolsConfig$jscomp$inline_1847 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-13942464"
reconcilerVersion: "19.0.0-www-classic-5bd4031226-20240530"
});
function ReactDOMRoot(internalRoot) {
this._internalRoot = internalRoot;
Expand Down Expand Up @@ -18373,7 +18376,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-13942464";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
13 changes: 8 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -17160,12 +17160,15 @@ function getCrossOriginStringAs(as, input) {
return "use-credentials" === input ? input : "";
}
var isomorphicReactPackageVersion$jscomp$inline_1811 = React.version;
if ("19.0.0-www-modern-8f46966d" !== isomorphicReactPackageVersion$jscomp$inline_1811)
if (
"19.0.0-www-modern-5bd4031226-20240530" !==
isomorphicReactPackageVersion$jscomp$inline_1811
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1811,
"19.0.0-www-modern-8f46966d"
"19.0.0-www-modern-5bd4031226-20240530"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17184,7 +17187,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1813 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-modern-8f46966d",
version: "19.0.0-www-modern-5bd4031226-20240530",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17228,7 +17231,7 @@ var devToolsConfig$jscomp$inline_1813 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-modern-8f46966d"
reconcilerVersion: "19.0.0-www-modern-5bd4031226-20240530"
});
function ReactDOMRoot(internalRoot) {
this._internalRoot = internalRoot;
Expand Down Expand Up @@ -17589,7 +17592,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-modern-8f46966d";
exports.version = "19.0.0-www-modern-5bd4031226-20240530";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '19.0.0-www-classic-d677c24a';
var ReactVersion = '19.0.0-www-classic-5bd4031226-20240530';

// This refers to a WWW module.
var warningWWW = require('warning');
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '19.0.0-www-modern-c13e0cef';
var ReactVersion = '19.0.0-www-modern-5bd4031226-20240530';

// This refers to a WWW module.
var warningWWW = require('warning');
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -5699,4 +5699,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-classic-444074d7";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -5677,4 +5677,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.0.0-www-modern-df91acfc";
exports.version = "19.0.0-www-modern-5bd4031226-20240530";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31625,7 +31625,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-www-classic-897ea709';
var ReactVersion = '19.0.0-www-classic-5bd4031226-20240530';

function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
implementation) {
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -30802,7 +30802,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
return root;
}

var ReactVersion = '19.0.0-www-modern-8ac3e0b0';
var ReactVersion = '19.0.0-www-modern-5bd4031226-20240530';

function createPortal$1(children, containerInfo, // TODO: figure out the API for cross-renderer implementation.
implementation) {
Expand Down
13 changes: 8 additions & 5 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17374,12 +17374,15 @@ function getCrossOriginStringAs(as, input) {
return "use-credentials" === input ? input : "";
}
var isomorphicReactPackageVersion$jscomp$inline_1783 = React.version;
if ("19.0.0-www-classic-1dd981af" !== isomorphicReactPackageVersion$jscomp$inline_1783)
if (
"19.0.0-www-classic-5bd4031226-20240530" !==
isomorphicReactPackageVersion$jscomp$inline_1783
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1783,
"19.0.0-www-classic-1dd981af"
"19.0.0-www-classic-5bd4031226-20240530"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17398,7 +17401,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1790 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "19.0.0-www-classic-1dd981af",
version: "19.0.0-www-classic-5bd4031226-20240530",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2239 = {
Expand Down Expand Up @@ -17428,7 +17431,7 @@ var internals$jscomp$inline_2239 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "19.0.0-www-classic-1dd981af"
reconcilerVersion: "19.0.0-www-classic-5bd4031226-20240530"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2240 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -18083,4 +18086,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-www-classic-1dd981af";
exports.version = "19.0.0-www-classic-5bd4031226-20240530";
Loading

0 comments on commit 0727c8a

Please sign in to comment.