Don't polyfill Number.isNaN globally.

facebook · Jan 10, 2016 · 0df4450 · 0df4450
1 parent 7c5390f
commit 0df4450
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/renderers/dom/shared/CSSPropertyOperations.js b/src/renderers/dom/shared/CSSPropertyOperations.js
@@ -11,8 +11,6 @@
 
 'use strict';
 
-require('Number.isNaN');
-
 var CSSProperty = require('CSSProperty');
 var ExecutionEnvironment = require('ExecutionEnvironment');
 var ReactPerf = require('ReactPerf');
@@ -21,6 +19,7 @@ var camelizeStyleName = require('camelizeStyleName');
 var dangerousStyleValue = require('dangerousStyleValue');
 var hyphenateStyleName = require('hyphenateStyleName');
 var memoizeStringOnly = require('memoizeStringOnly');
+var numberIsNaN = require('Number.isNaN');
 var warning = require('warning');
 
 var processStyleName = memoizeStringOnly(function(styleName) {
@@ -120,7 +119,7 @@ if (__DEV__) {
       warnBadVendoredStyleName(name);
     } else if (badStyleValueWithSemicolonPattern.test(value)) {
       warnStyleValueWithSemicolon(name, value);
-    } else if (Number.isNaN(value)) {
+    } else if (numberIsNaN(value)) {
       warnStyleValueWithNaN(name, value);
     }
   };

diff --git a/src/shared/stubs/Number.isNaN.js b/src/shared/stubs/Number.isNaN.js
@@ -11,8 +11,8 @@
 
 'use strict';
 
-/*eslint-disable no-self-compare */
-Number.isNaN = Number.isNaN || function(value) {     
+function numberIsNaN(value) {     
   return value !== value;
 };
-/*eslint-enable no-self-compare */
+
+module.exports = numberIsNaN;