Fix - issue #12765 / use wrapperState.initialChecked simplify the DOM

operations.
facebook · Jun 28, 2018 · 136bea6 · 136bea6
1 parent 3c670a4
commit 136bea6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMInput-test.js b/packages/react-dom/src/__tests__/ReactDOMInput-test.js
@@ -739,7 +739,7 @@ describe('ReactDOMInput', () => {
     const cNode = stub.refs.c;
 
     expect(aNode.checked).toBe(true);
-    expect(bNode.getAttribute('checked')).toBe(null);
+    expect(aNode.getAttribute('checked')).toBe('checked');
     expect(bNode.checked).toBe(false);
     expect(bNode.getAttribute('checked')).toBe(null);
     // c is in a separate form and shouldn't be affected at all here
@@ -754,7 +754,7 @@ describe('ReactDOMInput', () => {
     expect(cNode.checked).toBe(true);
 
     // The original 'checked' attribute should be unchanged
-    expect(aNode.getAttribute('checked')).toBe(null);
+    expect(aNode.getAttribute('checked')).toBe('checked');
     expect(bNode.getAttribute('checked')).toBe(null);
     expect(cNode.getAttribute('checked')).toBe('checked');
 

diff --git a/packages/react-dom/src/client/ReactDOMFiberInput.js b/packages/react-dom/src/client/ReactDOMFiberInput.js
@@ -245,7 +245,7 @@ export function postMountWrapper(
   node.defaultChecked = !node.defaultChecked;
   node.defaultChecked = !node.defaultChecked;
   // Set the "checked" attribute initially.
-  if (props.hasOwnProperty('defaultChecked') && !!props.defaultChecked) {
+  if (node._wrapperState.initialChecked) {
     node.setAttribute('checked', 'checked');
   }
   if (name !== '') {