[act] remove obsolete container element

In a previous version of `act()`, we used a dummy dom element to flush effects and such. This doesn't need to exist anymore. The warning itself is still useful, so we'll keep it. Updated the test.
facebook · Aug 7, 2019 · 1e3aef4 · 1e3aef4
1 parent c4f0b93
commit 1e3aef4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 19 deletions.
diff --git a/packages/react-dom/src/test-utils/ReactTestUtils.js b/packages/react-dom/src/test-utils/ReactTestUtils.js
@@ -153,9 +153,6 @@ function validateClassInstance(inst, methodName) {
   );
 }
 
-// a plain dom element, lazily initialized, used by act() when flushing effects
-let actContainerElement = null;
-
 // a warning for when you try to use TestUtils.act in a non-browser environment
 let didWarnAboutActInNodejs = false;
 
@@ -396,21 +393,17 @@ const ReactTestUtils = {
   SimulateNative: {},
 
   act(callback: () => Thenable) {
-    if (actContainerElement === null) {
-      if (__DEV__) {
-        // warn if we're trying to use this in something like node (without jsdom)
-        if (didWarnAboutActInNodejs === false) {
-          didWarnAboutActInNodejs = true;
-          warningWithoutStack(
-            typeof document !== 'undefined' && document !== null,
-            'It looks like you called ReactTestUtils.act(...) in a non-browser environment. ' +
-              "If you're using TestRenderer for your tests, you should call " +
-              'ReactTestRenderer.act(...) instead of ReactTestUtils.act(...).',
-          );
-        }
+    if (__DEV__) {
+      // warn if we're trying to use this in something like node (without jsdom)
+      if (didWarnAboutActInNodejs === false) {
+        didWarnAboutActInNodejs = true;
+        warningWithoutStack(
+          typeof document !== 'undefined' && document !== null,
+          'It looks like you called ReactTestUtils.act(...) in a non-browser environment. ' +
+            "If you're using TestRenderer for your tests, you should call " +
+            'ReactTestRenderer.act(...) instead of ReactTestUtils.act(...).',
+        );
       }
-      // now make the stub element
-      actContainerElement = document.createElement('div');
     }
     return act(callback);
   },

diff --git a/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js b/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js
@@ -1024,13 +1024,13 @@ describe('ReactTestRenderer', () => {
   });
 
   // we run this test here because we need a dom-less scope
-  it('warns and throws if you use TestUtils.act instead of TestRenderer.act in node', () => {
+  it('warns if you use TestUtils.act instead of TestRenderer.act in node', () => {
     // we warn when you try to load 2 renderers in the same 'scope'
     // so as suggested, we call resetModules() to carry on with the test
     jest.resetModules();
     const {act} = require('react-dom/test-utils');
     expect(() => {
-      expect(() => act(() => {})).toThrow('document is not defined');
+      act(() => {});
     }).toWarnDev(
       [
         'It looks like you called ReactTestUtils.act(...) in a non-browser environment',