feedback: change Array.from(children) -> querySelectorAll

facebook · Mar 4, 2023 · 1e5e9af · 1e5e9af
1 parent b5a3537
commit 1e5e9af
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/react-dom-bindings/src/server/ReactDOMServerExternalRuntime.js b/packages/react-dom-bindings/src/server/ReactDOMServerExternalRuntime.js
@@ -51,7 +51,7 @@ if (document.body != null) {
 }
 
 function handleExistingNodes(target /*: HTMLElement */) {
-  const existingNodes = Array.from(target.children);
+  const existingNodes = target.querySelectorAll('template');
   for (let i = 0; i < existingNodes.length; i++) {
     handleNode(existingNodes[i]);
   }
@@ -62,8 +62,8 @@ function installFizzInstrObserver(target /*: Node */) {
     for (let i = 0; i < mutations.length; i++) {
       const addedNodes = mutations[i].addedNodes;
       for (let j = 0; j < addedNodes.length; j++) {
-        if (addedNodes.item(j).parentNode) {
-          handleNode(addedNodes.item(j));
+        if (addedNodes[j].parentNode) {
+          handleNode(addedNodes[j]);
         }
       }
     }