Skip to content

Commit

Permalink
(chore): copy fix in <style> precedence error (#31524)
Browse files Browse the repository at this point in the history
## Summary

This fixes a typo in the error that gets reported when Float errors
while hoisting a style tag that does not contain both `precedence` and
`href`. There was a typo in _conflict_ and the last part of the sentence
doesn't make sense. I assume it wasn't needed since the message already
suggests moving the style tag to the head manually.

DiffTrain build for [63cde68](63cde68)
  • Loading branch information
gnoff committed Nov 14, 2024
1 parent 5834fcd commit 23caea5
Show file tree
Hide file tree
Showing 23 changed files with 88 additions and 88 deletions.
2 changes: 1 addition & 1 deletion compiled-rn/VERSION_NATIVE_FB
Original file line number Diff line number Diff line change
@@ -1 +1 @@
19.0.0-native-fb-988e2176-20241114
19.0.0-native-fb-63cde684-20241114
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<a4df38841b77f6a55652fed7991738c3>>
* @generated SignedSource<<8db1f8874a2129441c0608ba9c2990d8>>
*/

"use strict";
Expand Down Expand Up @@ -420,5 +420,5 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
})();
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<ea9b2f92a239852ee39344b0bd1ee93d>>
* @generated SignedSource<<83fb924d282a538071fd7ba1e0da3445>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<ea9b2f92a239852ee39344b0bd1ee93d>>
* @generated SignedSource<<83fb924d282a538071fd7ba1e0da3445>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<78d31aca60ff2b747836be09c369876e>>
* @generated SignedSource<<08dd0acbab1ea61c3d23358abf5fa96d>>
*/

/*
Expand Down Expand Up @@ -20607,7 +20607,7 @@ __DEV__ &&
) {
outsideHostContainerContext &&
error$jscomp$0(
'Cannot render a <style> outside the main document without knowing its precedence and a unique href key. React can hoist and deduplicate <style> tags if you provide a `precedence` prop along with an `href` prop that does not conflic with the `href` values used in any other hoisted <style> or <link rel="stylesheet" ...> tags. Note that hoisting <style> tags is considered an advanced feature that most will not use directly. Consider moving the <style> tag to the <head> or consider adding a `precedence="default"` and `href="some unique resource identifier"`, or move the <style> to the <style> tag.'
'Cannot render a <style> outside the main document without knowing its precedence and a unique href key. React can hoist and deduplicate <style> tags if you provide a `precedence` prop along with an `href` prop that does not conflict with the `href` values used in any other hoisted <style> or <link rel="stylesheet" ...> tags. Note that hoisting <style> tags is considered an advanced feature that most will not use directly. Consider moving the <style> tag to the <head> or consider adding a `precedence="default"` and `href="some unique resource identifier"`.'
);
break;
}
Expand Down Expand Up @@ -25352,11 +25352,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-native-fb-988e2176-20241114" !== isomorphicReactPackageVersion)
if ("19.0.0-native-fb-63cde684-20241114" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-native-fb-988e2176-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-native-fb-63cde684-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -25393,11 +25393,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114"
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -25541,5 +25541,5 @@ __DEV__ &&
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
})();
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<146f7449d33c26a6a5194d9cc4c1830b>>
* @generated SignedSource<<383cd4c74944d46d35e2103fce56eba2>>
*/

/*
Expand Down Expand Up @@ -15638,14 +15638,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1698 = React.version;
if (
"19.0.0-native-fb-988e2176-20241114" !==
"19.0.0-native-fb-63cde684-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1698
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1698,
"19.0.0-native-fb-988e2176-20241114"
"19.0.0-native-fb-63cde684-20241114"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -15667,11 +15667,11 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2156 = {
bundleType: 0,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114"
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2157 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15775,4 +15775,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<0f082fd90e3fd34da4562cef8ba9802b>>
* @generated SignedSource<<b5c365d14ccc268d0c0f4bac4dfde906>>
*/

/*
Expand Down Expand Up @@ -16292,14 +16292,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1788 = React.version;
if (
"19.0.0-native-fb-988e2176-20241114" !==
"19.0.0-native-fb-63cde684-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1788
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1788,
"19.0.0-native-fb-988e2176-20241114"
"19.0.0-native-fb-63cde684-20241114"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -16321,11 +16321,11 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_1795 = {
bundleType: 0,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114",
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$291 = 0;
Expand Down Expand Up @@ -16444,4 +16444,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<d6b3ef2d6648bde050c5cab6e0d2103e>>
* @generated SignedSource<<a721c4b51aa5ed4b7ecde97e962aeb6c>>
*/

/*
Expand Down Expand Up @@ -20619,7 +20619,7 @@ __DEV__ &&
) {
outsideHostContainerContext &&
error$jscomp$0(
'Cannot render a <style> outside the main document without knowing its precedence and a unique href key. React can hoist and deduplicate <style> tags if you provide a `precedence` prop along with an `href` prop that does not conflic with the `href` values used in any other hoisted <style> or <link rel="stylesheet" ...> tags. Note that hoisting <style> tags is considered an advanced feature that most will not use directly. Consider moving the <style> tag to the <head> or consider adding a `precedence="default"` and `href="some unique resource identifier"`, or move the <style> to the <style> tag.'
'Cannot render a <style> outside the main document without knowing its precedence and a unique href key. React can hoist and deduplicate <style> tags if you provide a `precedence` prop along with an `href` prop that does not conflict with the `href` values used in any other hoisted <style> or <link rel="stylesheet" ...> tags. Note that hoisting <style> tags is considered an advanced feature that most will not use directly. Consider moving the <style> tag to the <head> or consider adding a `precedence="default"` and `href="some unique resource identifier"`.'
);
break;
}
Expand Down Expand Up @@ -25413,11 +25413,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.0.0-native-fb-988e2176-20241114" !== isomorphicReactPackageVersion)
if ("19.0.0-native-fb-63cde684-20241114" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.0.0-native-fb-988e2176-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.0.0-native-fb-63cde684-20241114\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -25454,11 +25454,11 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114"
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -25918,7 +25918,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<b94ff7a08de017a8767c0961349ed00e>>
* @generated SignedSource<<3c16b4c8e838f4c370d0e5196f6c39af>>
*/

/*
Expand Down Expand Up @@ -15649,14 +15649,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1699 = React.version;
if (
"19.0.0-native-fb-988e2176-20241114" !==
"19.0.0-native-fb-63cde684-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1699
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1699,
"19.0.0-native-fb-988e2176-20241114"
"19.0.0-native-fb-63cde684-20241114"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -15678,11 +15678,11 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2159 = {
bundleType: 0,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114"
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2160 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15940,4 +15940,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<be81ec4c85b3b330679e5f47e50f8a25>>
* @generated SignedSource<<1d65bbab861baa21e3ad74357f3f13d8>>
*/

/*
Expand Down Expand Up @@ -16307,14 +16307,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1789 = React.version;
if (
"19.0.0-native-fb-988e2176-20241114" !==
"19.0.0-native-fb-63cde684-20241114" !==
isomorphicReactPackageVersion$jscomp$inline_1789
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1789,
"19.0.0-native-fb-988e2176-20241114"
"19.0.0-native-fb-63cde684-20241114"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
Expand All @@ -16336,11 +16336,11 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_1796 = {
bundleType: 0,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getClosestInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114",
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$291 = 0;
Expand Down Expand Up @@ -16613,7 +16613,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<0442689d6b267f9dc20b1444ccb6e111>>
* @generated SignedSource<<859b4c831071d64575318e94ba73e9e8>>
*/

"use strict";
Expand Down Expand Up @@ -15191,11 +15191,11 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.0.0-native-fb-988e2176-20241114",
version: "19.0.0-native-fb-63cde684-20241114",
rendererPackageName: "react-test-renderer",
currentDispatcherRef: ReactSharedInternals,
findFiberByHostInstance: getInstanceFromNode,
reconcilerVersion: "19.0.0-native-fb-988e2176-20241114"
reconcilerVersion: "19.0.0-native-fb-63cde684-20241114"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -15340,5 +15340,5 @@ __DEV__ &&
flushSyncWorkAcrossRoots_impl(0, !0));
}
};
exports.version = "19.0.0-native-fb-988e2176-20241114";
exports.version = "19.0.0-native-fb-63cde684-20241114";
})();
Loading

0 comments on commit 23caea5

Please sign in to comment.