Move modern strict to experimental

facebook · Jan 29, 2024 · 2460666 · 2460666
1 parent 4d6c47b
commit 2460666
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 10 deletions.
diff --git a/packages/react/src/__tests__/ReactStrictMode-test.js b/packages/react/src/__tests__/ReactStrictMode-test.js
@@ -115,15 +115,29 @@ describe('ReactStrictMode', () => {
       container,
     );
 
-    expect(log).toEqual([
-      'constructor',
-      'constructor',
-      'getDerivedStateFromProps',
-      'getDerivedStateFromProps',
-      'render',
-      'render',
-      'componentDidMount',
-    ]);
+    if (gate(flags => flags.useModernStrictMode)) {
+      expect(log).toEqual([
+        'constructor',
+        'constructor',
+        'getDerivedStateFromProps',
+        'getDerivedStateFromProps',
+        'render',
+        'render',
+        'componentDidMount',
+        'componentWillUnmount',
+        'componentDidMount',
+      ]);
+    } else {
+      expect(log).toEqual([
+        'constructor',
+        'constructor',
+        'getDerivedStateFromProps',
+        'getDerivedStateFromProps',
+        'render',
+        'render',
+        'componentDidMount',
+      ]);
+    }
 
     log = [];
     shouldComponentUpdate = true;

diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js
@@ -147,7 +147,7 @@ export const disableJavaScriptURLs = false;
 // Modern <StrictMode /> behaviour aligns more with what components
 // components will encounter in production, especially when used With <Offscreen />.
 // TODO: clean up legacy <StrictMode /> once tests pass WWW.
-export const useModernStrictMode = false;
+export const useModernStrictMode = __NEXT_MAJOR__;
 
 // Not ready to break experimental yet.
 // Remove IE and MsApp specific workarounds for innerHTML