Re-eliminate the postmount wrapper with a special defaultValue mutati…

…on method
facebook · Aug 13, 2016 · 30fa07c · 30fa07c
1 parent bae6fa4
commit 30fa07c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 22 deletions.
diff --git a/src/renderers/dom/client/wrappers/ReactDOMInput.js b/src/renderers/dom/client/wrappers/ReactDOMInput.js
@@ -178,17 +178,6 @@ var ReactDOMInput = {
     }
   },
 
-  postMountWrapper: function(inst) {
-    var node = ReactDOMComponentTree.getNodeFromInstance(inst);
-    var props = inst._currentElement.props;
-
-    // Values derived from markup, like setting innerHTML or working
-    // from server-rendered markup, will not have value assigned as a
-    // property. It needs to be directly assigned to detatch it from
-    // default value.
-    node.value = node.value;
-  },
-
   // Ensure that there is no disconnect between an input's property
   // value and component state. This should run during `onChange`.
   enforceControlledInputValue: function(inst) {

diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js
@@ -771,7 +771,6 @@ describe('ReactDOMInput', function() {
       'set min',
       'set max',
       'set value',
-      'set value' // second time is post mount
     ]);
   });
 

diff --git a/src/renderers/dom/shared/HTMLDOMPropertyConfig.js b/src/renderers/dom/shared/HTMLDOMPropertyConfig.js
@@ -40,7 +40,7 @@ var HTMLDOMPropertyConfig = {
       'min',
       'max',
       'value',
-      'checked'
+      'checked',
     ],
   },
 
@@ -246,6 +246,19 @@ var HTMLDOMPropertyConfig = {
       }
     },
 
+    defaultValue: function(node, next) {
+      // If a value is present, intentially re-assign it to detatch it
+      // from defaultValue. Values derived from server-rendered markup
+      // will not had a prior changes to assign value as a property.
+      //
+      // Make an exception for multi-selects
+      if (!node.multiple && node.value !== '') {
+        node.value = node.value;
+      }
+
+      node.defaultValue = next;
+    },
+
     // Chrome ~50 does not properly detatch defaultChecked, this mutation method
     // is a work around to mitigate a bug where setting defaultChecked changes
     // the value of checked, even after detachment:

diff --git a/src/renderers/dom/shared/ReactDOMComponent.js b/src/renderers/dom/shared/ReactDOMComponent.js
@@ -239,11 +239,6 @@ function putListener() {
   );
 }
 
-function inputPostMount() {
-  var inst = this;
-  ReactDOMInput.postMountWrapper(inst);
-}
-
 function textareaPostMount() {
   var inst = this;
   ReactDOMTextarea.postMountWrapper(inst);
@@ -658,10 +653,6 @@ ReactDOMComponent.Mixin = {
 
     switch (this._tag) {
       case 'input':
-        transaction.getReactMountReady().enqueue(
-          inputPostMount,
-          this
-        );
         if (props.autoFocus) {
           transaction.getReactMountReady().enqueue(
             AutoFocusUtils.focusDOMComponent,