Skip to content

Commit

Permalink
disable enableSiblingPrerendering in experimental channel
Browse files Browse the repository at this point in the history
Disables `enableSiblingPrerendering` in the experimental builds until the feature is tested at Meta first.
  • Loading branch information
gnoff committed Sep 12, 2024
1 parent 4735220 commit 3c515e4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ import semver from 'semver';
// TODO: This is how other DevTools tests access the version but we should find
// a better solution for this
const ReactVersionTestingAgainst = process.env.REACT_VERSION || ReactVersion;
const enableSiblingPrerendering = semver.gte(
ReactVersionTestingAgainst,
'19.0.0',
);
// Disabling this while the flag is off in experimental. Leaving the logic so we can
// restore the behavior when we turn the flag back on.
const enableSiblingPrerendering =
false && semver.gte(ReactVersionTestingAgainst, '19.0.0');

describe('Timeline profiler', () => {
let React;
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/ReactFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const enableOwnerStacks = __EXPERIMENTAL__;

export const enableShallowPropDiffing = false;

export const enableSiblingPrerendering = __EXPERIMENTAL__;
export const enableSiblingPrerendering = false;

/**
* Enables an expiration time for retry lanes to avoid starvation.
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/forks/ReactFeatureFlags.test-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const enableAddPropertiesFastPath = false;

export const renameElementSymbol = true;
export const enableShallowPropDiffing = false;
export const enableSiblingPrerendering = __EXPERIMENTAL__;
export const enableSiblingPrerendering = false;

// TODO: This must be in sync with the main ReactFeatureFlags file because
// the Test Renderer's value must be the same as the one used by the
Expand Down

0 comments on commit 3c515e4

Please sign in to comment.