Rename variable + strongly type stateNode

facebook · Dec 5, 2022 · 3eb1803 · 3eb1803
1 parent 469eaf7
commit 3eb1803
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.js b/packages/react-reconciler/src/ReactFiberBeginWork.js
@@ -685,7 +685,7 @@ function updateOffscreenComponent(
 ) {
   const nextProps: OffscreenProps = workInProgress.pendingProps;
   const nextChildren = nextProps.children;
-  const isPendingDetached =
+  const nextIsDetached =
     (workInProgress.stateNode._pendingVisibility & OffscreenDetached) !== 0;
 
   const prevState: OffscreenState | null =
@@ -697,7 +697,7 @@ function updateOffscreenComponent(
     nextProps.mode === 'hidden' ||
     (enableLegacyHidden &&
       nextProps.mode === 'unstable-defer-without-hiding') ||
-    isPendingDetached
+    nextIsDetached
   ) {
     // Rendering a hidden tree.
 

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js
@@ -2876,18 +2876,19 @@ function commitMutationEffectsOnFiber(
       }
 
       commitReconciliationEffects(finishedWork);
+
+      const offscreenInstance: OffscreenInstance = finishedWork.stateNode;
+
       // TODO: Add explicit effect flag to set _current.
-      finishedWork.stateNode._current = finishedWork;
+      offscreenInstance._current = finishedWork;
 
       // Offscreen stores pending changes to visibility in `_pendingVisibility`. This is
       // to support batching of `attach` and `detach` calls.
-      finishedWork.stateNode._visibility &= ~OffscreenDetached;
-      finishedWork.stateNode._visibility |=
-        finishedWork.stateNode._pendingVisibility & OffscreenDetached;
+      offscreenInstance._visibility &= ~OffscreenDetached;
+      offscreenInstance._visibility |=
+        offscreenInstance._pendingVisibility & OffscreenDetached;
 
       if (flags & Visibility) {
-        const offscreenInstance: OffscreenInstance = finishedWork.stateNode;
-
         // Track the current state on the Offscreen instance so we can
         // read it during an event
         if (isHidden) {