Merged master (with events -> legacy-events package rename)

.circleci/config.yml

@@ -94,16 +94,6 @@ jobs:
       - *run_yarn
       - run: yarn test-prod --maxWorkers=2
 
-  test_coverage:
-    docker: *docker
-    environment: *environment
-
-    steps:
-      - checkout
-      - *restore_yarn_cache
-      - *run_yarn
-      - run: ./scripts/circleci/test_coverage.sh
-
   build:
     docker: *docker
     environment: *environment
@@ -257,6 +247,3 @@ workflows:
       - test_fuzz:
           requires:
             - setup
-      - test_coverage:
-          requires:
-            - setup

.eslintrc.js

@@ -129,6 +129,8 @@ module.exports = {
       rules: {
         // https://github.com/jest-community/eslint-plugin-jest
         'jest/no-focused-tests': ERROR,
+        'jest/valid-expect': ERROR,
+        'jest/valid-expect-in-promise': ERROR,
       },
     },
     {
@@ -140,6 +142,8 @@ module.exports = {
   ],
 
   globals: {
+    SharedArrayBuffer: true,
+
     spyOnDev: true,
     spyOnDevAndProd: true,
     spyOnProd: true,

fixtures/ssr/src/components/Chrome.js

@@ -26,7 +26,16 @@ export default class Chrome extends Component {
           <Theme.Provider value={this.state.theme}>
             {this.props.children}
             <div>
-              <ThemeToggleButton onChange={theme => this.setState({theme})} />
+              <ThemeToggleButton
+                onChange={theme => {
+                  React.unstable_withSuspenseConfig(
+                    () => {
+                      this.setState({theme});
+                    },
+                    {timeoutMs: 6000}
+                  );
+                }}
+              />
             </div>
           </Theme.Provider>
           <script

package.json

@@ -48,7 +48,7 @@
     "eslint": "^6.1.0",
     "eslint-config-fbjs": "^1.1.1",
     "eslint-plugin-flowtype": "^2.25.0",
-    "eslint-plugin-jest": "^21.6.1",
+    "eslint-plugin-jest": "^22.15.0",
     "eslint-plugin-no-for-of-loops": "^1.0.0",
     "eslint-plugin-babel": "^5.3.0",
     "eslint-plugin-react": "^6.7.1",

packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js

@@ -521,7 +521,6 @@ const tests = {
       // Valid because the ref is captured.
       code: `
         function useMyThing(myRef) {
-          const myRef = useRef();
           useEffect(() => {
             const handleMove = () => {};
             const node = myRef.current;
@@ -1024,6 +1023,28 @@ const tests = {
         }
       `,
     },
+    // Ignore arguments keyword for arrow functions.
+    {
+      code: `
+        function Example() {
+          useEffect(() => {
+            arguments
+          }, [])
+        }
+      `,
+    },
+    {
+      code: `
+        function Example() {
+          useEffect(() => {
+            const bar = () => {
+              arguments;
+            };
+            bar();
+          }, [])
+        }
+      `,
+    },
   ],
   invalid: [
     {

packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js

@@ -95,7 +95,7 @@ eslintTester.run('react-hooks', ReactHooksESLintRule, {
       useHook2 = () => { useState(); };
       ({useHook: () => { useState(); }});
       ({useHook() { useState(); }});
-      const {useHook = () => { useState(); }} = {};
+      const {useHook3 = () => { useState(); }} = {};
       ({useHook = () => { useState(); }} = {});
     `,
     `

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -397,13 +397,14 @@ export default {
             });
           }
 
-          // Ignore references to the function itself as it's not defined yet.
           const def = reference.resolved.defs[0];
-          if (
-            def != null &&
-            def.node != null &&
-            def.node.init === node.parent
-          ) {
+
+          if (def == null) {
+            continue;
+          }
+
+          // Ignore references to the function itself as it's not defined yet.
+          if (def.node != null && def.node.init === node.parent) {
             continue;
           }
 

packages/events/__tests__/EventPluginRegistry-test.internal.js → packages/legacy-events/__tests__/EventPluginRegistry-test.internal.js

@@ -19,7 +19,7 @@ describe('EventPluginRegistry', () => {
     // The public API surface of this is covered by other tests so
     // if `EventPluginRegistry` is ever deleted, these tests should be
     // safe to remove too.
-    EventPluginRegistry = require('events/EventPluginRegistry');
+    EventPluginRegistry = require('legacy-events/EventPluginRegistry');
 
     createPlugin = function(properties) {
       return Object.assign({extractEvents: function() {}}, properties);

packages/events/__tests__/ResponderEventPlugin-test.internal.js → packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js

@@ -403,8 +403,8 @@ describe('ResponderEventPlugin', () => {
     jest.resetModules();
 
     const ReactDOMUnstableNativeDependencies = require('react-dom/unstable-native-dependencies');
-    EventBatching = require('events/EventBatching');
-    EventPluginUtils = require('events/EventPluginUtils');
+    EventBatching = require('legacy-events/EventBatching');
+    EventPluginUtils = require('legacy-events/EventPluginUtils');
     ResponderEventPlugin =
       ReactDOMUnstableNativeDependencies.ResponderEventPlugin;
 

packages/events/__tests__/accumulate-test.internal.js → packages/legacy-events/__tests__/accumulate-test.internal.js

@@ -13,7 +13,7 @@ let accumulate;
 
 describe('accumulate', () => {
   beforeEach(() => {
-    accumulate = require('events/accumulate').default;
+    accumulate = require('legacy-events/accumulate').default;
   });
 
   it('throws if the second item is null', () => {

packages/events/__tests__/accumulateInto-test.internal.js → packages/legacy-events/__tests__/accumulateInto-test.internal.js

@@ -13,7 +13,7 @@ let accumulateInto;
 
 describe('accumulateInto', () => {
   beforeEach(() => {
-    accumulateInto = require('events/accumulateInto').default;
+    accumulateInto = require('legacy-events/accumulateInto').default;
   });
 
   it('throws if the second item is null', () => {

packages/events/package.json → packages/legacy-events/package.json

@@ -1,5 +1,5 @@
 {
   "private": true,
-  "name": "events",
+  "name": "legacy-events",
   "version": "0.0.0"
 }

packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js

@@ -57,8 +57,8 @@ describe('ReactBrowserEventEmitter', () => {
     LISTENER.mockClear();
 
     // TODO: can we express this test with only public API?
-    EventPluginHub = require('events/EventPluginHub');
-    EventPluginRegistry = require('events/EventPluginRegistry');
+    EventPluginHub = require('legacy-events/EventPluginHub');
+    EventPluginRegistry = require('legacy-events/EventPluginRegistry');
     React = require('react');
     ReactDOM = require('react-dom');
     ReactDOMComponentTree = require('../client/ReactDOMComponentTree');

packages/react-dom/src/__tests__/ReactDOMComponent-test.js

@@ -1040,7 +1040,7 @@ describe('ReactDOMComponent', () => {
       if (typeof value !== 'undefined') {
         re += quoteRegexp(value) + '[\\\'"]';
       }
-      expect(new RegExp(re).test(actual)).toBe(true);
+      expect(actual).toMatch(new RegExp(re));
     }
 
     function genMarkup(props) {

packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js

@@ -651,7 +651,7 @@ describe('ReactDOMServerIntegration', () => {
       });
     });
 
-    describe('component hierarchies', async function() {
+    describe('component hierarchies', function() {
       itRenders('single child hierarchies of components', async render => {
         const Component = props => <div>{props.children}</div>;
         let e = await render(