Add test case for progress elements

facebook · Sep 29, 2016 · 4e5ac47 · 4e5ac47
1 parent 5d8c8ef
commit 4e5ac47
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js b/src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js
@@ -824,7 +824,7 @@ describe('ReactDOMInput', () => {
   });
 
   it('sets type, step, min, max before value always', () => {
-    if (!ReactDOMFeatureFlags.useCreateElement) {
+    if (!ReactDOMFeatureFlags.us3eCreateElement) {
       return;
     }
     var log = [];
@@ -852,7 +852,8 @@ describe('ReactDOMInput', () => {
       'set step',
       'set min',
       'set max',
-      'set value',
+      'set value', // attribute
+      'set value', // property
     ]);
   });
 

diff --git a/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js b/src/renderers/dom/shared/__tests__/DOMPropertyOperations-test.js
@@ -381,6 +381,19 @@ describe('DOMPropertyOperations', () => {
       expect(stubNode.value).toBe('');
     });
 
+    it('should always assign the value attribute for non-inputs', function() {
+      var stubNode = document.createElement('progress');
+      var stubInstance = {_debugID: 1};
+      ReactDOMComponentTree.precacheNode(stubInstance, stubNode);
+
+      spyOn(stubNode, 'setAttribute');
+
+      DOMPropertyOperations.setValueForProperty(stubNode, 'value', 30);
+      DOMPropertyOperations.setValueForProperty(stubNode, 'value', '30');
+
+      expect(stubNode.setAttribute.calls.count()).toBe(2);
+    });
+
     it('should not leave all options selected when deleting multiple', () => {
       stubNode = document.createElement('select');
       ReactDOMComponentTree.precacheNode(stubInstance, stubNode);