Skip to content

Commit

Permalink
[cleanup] remove unused values from ReactFeatureFlags.www-dynamic (#2…
Browse files Browse the repository at this point in the history
…5575)

These values are never imported into `ReactFeatureFlags.www.js`, so
they're unused:
- `allowConcurrentByDefault`
- `consoleManagedByDevToolsDuringStrictMode`

These values are never set in the WWW module
(https://fburl.com/code/dsb2ohv8), so they're always `undefined` on www:
- `createRootStrictEffectsByDefault`
- `enableClientRenderFallbackOnTextMismatch`

DiffTrain build for [7002a67](7002a67)
[View git log for this commit](https://github.com/facebook/react/commits/7002a6743ebb24ed55af8f626c89dd39460230fc)
  • Loading branch information
kassens committed Jan 11, 2023
1 parent 198e9a4 commit 84aa038
Show file tree
Hide file tree
Showing 37 changed files with 192 additions and 334 deletions.
4 changes: 0 additions & 4 deletions compiled/facebook-www/JSXDEVRuntime-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -134,8 +132,6 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
Expand Down
4 changes: 0 additions & 4 deletions compiled/facebook-www/JSXDEVRuntime-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -134,8 +132,6 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
fb324faf8a3da08212bcc5ea9e3a084dbfa80dad
7002a6743ebb24ed55af8f626c89dd39460230fc
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
fb324faf8a3da08212bcc5ea9e3a084dbfa80dad
7002a6743ebb24ed55af8f626c89dd39460230fc
6 changes: 1 addition & 5 deletions compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-classic-7002a6743-20230110";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -492,8 +492,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -505,8 +503,6 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
Expand Down
6 changes: 1 addition & 5 deletions compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-modern-7002a6743-20230110";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -492,8 +492,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -505,8 +503,6 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-fb324faf8-20230110";
exports.version = "18.3.0-www-classic-7002a6743-20230110";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-fb324faf8-20230110";
exports.version = "18.3.0-www-modern-7002a6743-20230110";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-fb324faf8-20230110";
exports.version = "18.3.0-www-classic-7002a6743-20230110";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-fb324faf8-20230110";
exports.version = "18.3.0-www-modern-7002a6743-20230110";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
7 changes: 2 additions & 5 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-classic-7002a6743-20230110";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -181,8 +181,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -194,14 +192,13 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var createRootStrictEffectsByDefault = false;

var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation.
var warnAboutStringRefs = true;
Expand Down
7 changes: 2 additions & 5 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-modern-7002a6743-20230110";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -181,8 +181,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -194,14 +192,13 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var createRootStrictEffectsByDefault = false;

var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation.
var warnAboutStringRefs = true;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9804,7 +9804,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-fb324faf8-20230110",
version: "18.3.0-www-classic-7002a6743-20230110",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1318 = {
Expand Down Expand Up @@ -9835,7 +9835,7 @@ var internals$jscomp$inline_1318 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-fb324faf8-20230110"
reconcilerVersion: "18.3.0-next-7002a6743-20230110"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9471,7 +9471,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-fb324faf8-20230110",
version: "18.3.0-www-modern-7002a6743-20230110",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1309 = {
Expand Down Expand Up @@ -9502,7 +9502,7 @@ var internals$jscomp$inline_1309 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-fb324faf8-20230110"
reconcilerVersion: "18.3.0-next-7002a6743-20230110"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
8 changes: 3 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -64,14 +62,14 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var createRootStrictEffectsByDefault = false;
var enableClientRenderFallbackOnTextMismatch = false; // Logs additional User Timing API marks for use with an experimental profiling tool.

var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation.
var warnAboutStringRefs = true;
Expand Down Expand Up @@ -42697,7 +42695,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-classic-7002a6743-20230110";

function createPortal(
children,
Expand Down
8 changes: 3 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ var disableInputAttributeSyncing =
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
createRootStrictEffectsByDefault =
dynamicFeatureFlags.createRootStrictEffectsByDefault,
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
disableNativeComponentFrames =
dynamicFeatureFlags.disableNativeComponentFrames,
Expand All @@ -168,14 +166,14 @@ var disableInputAttributeSyncing =
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var createRootStrictEffectsByDefault = false;
var enableClientRenderFallbackOnTextMismatch = false; // Logs additional User Timing API marks for use with an experimental profiling tool.

var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation.
var warnAboutStringRefs = true;
Expand Down Expand Up @@ -42421,7 +42419,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-fb324faf8-20230110";
var ReactVersion = "18.3.0-www-modern-7002a6743-20230110";

function createPortal(
children,
Expand Down
Loading

0 comments on commit 84aa038

Please sign in to comment.