Skip to content

Commit

Permalink
Rename yarn build-combined to just yarn build
Browse files Browse the repository at this point in the history
It's confusing to new contributors, and me, that you're supposed to use `yarn build-combined` for almost everything but not fixtures.

We should use only one build command for everything.
  • Loading branch information
sebmarkbage committed Feb 17, 2023
1 parent 1a49e2d commit 8a76bfd
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
22 changes: 11 additions & 11 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ jobs:
paths:
- build

yarn_build_combined:
yarn_build:
docker: *docker
environment: *environment
parallelism: 40
steps:
- checkout
- setup_node_modules
- run: yarn build-combined
- run: yarn build
- persist_to_workspace:
root: .
paths:
Expand Down Expand Up @@ -451,7 +451,7 @@ workflows:
# TODO: Test more persistent configurations?
- '-r=stable --env=development --persistent'
- '-r=experimental --env=development --persistent'
- yarn_build_combined:
- yarn_build:
filters:
branches:
ignore:
Expand All @@ -464,10 +464,10 @@ workflows:
- process_artifacts_combined:
requires:
- scrape_warning_messages
- yarn_build_combined
- yarn_build
- yarn_test_build:
requires:
- yarn_build_combined
- yarn_build
matrix:
parameters:
args:
Expand Down Expand Up @@ -506,22 +506,22 @@ workflows:
- main
requires:
- download_base_build_for_sizebot
- yarn_build_combined
- yarn_build
- yarn_lint_build:
requires:
- yarn_build_combined
- yarn_build
- yarn_check_release_dependencies:
requires:
- yarn_build_combined
- yarn_build
- check_error_codes:
requires:
- yarn_build_combined
- yarn_build
- RELEASE_CHANNEL_stable_yarn_test_dom_fixtures:
requires:
- yarn_build_combined
- yarn_build
- build_devtools_and_process_artifacts:
requires:
- yarn_build_combined
- yarn_build
- run_devtools_e2e_tests:
requires:
- build_devtools_and_process_artifacts
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@
"testRegex": "/scripts/jest/dont-run-jest-directly\\.js$"
},
"scripts": {
"build": "node ./scripts/rollup/build.js",
"build-combined": "node ./scripts/rollup/build-all-release-channels.js",
"build": "node ./scripts/rollup/build-all-release-channels.js",
"build-combined": "echo 'build-combined is deprecated. yarn build instead.'",
"build-for-devtools": "cross-env RELEASE_CHANNEL=experimental yarn build react/index,react/jsx,react-dom/index,react-dom/unstable_testing,react-dom/test-utils,react-is,react-debug-tools,scheduler,react-test-renderer,react-refresh,react-art --type=NODE && cp -r ./build/node_modules build/oss-experimental/",
"build-for-devtools-dev": "yarn build-for-devtools --type=NODE_DEV",
"build-for-devtools-prod": "yarn build-for-devtools --type=NODE_PROD",
Expand Down

0 comments on commit 8a76bfd

Please sign in to comment.