-
Notifications
You must be signed in to change notification settings - Fork 47.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[compiler] Don't include current field accesses in auto-deps
## Summary Drops .current field accesses in inferred dep arrays
- Loading branch information
Showing
3 changed files
with
123 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
...react-compiler/src/__tests__/fixtures/compiler/nonreactive-ref-helper.expect.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
|
||
## Input | ||
|
||
```javascript | ||
// @inferEffectDependencies | ||
import {useEffect} from 'react'; | ||
import {print} from 'shared-runtime'; | ||
|
||
/** | ||
* We never include a .current access in a dep array because it may be a ref access. | ||
* This might over-capture objects that are not refs and happen to have fields named | ||
* current, but that should be a rare case and the result would still be correct | ||
* (assuming the effect is idempotent). In the worst case, you can always write a manual | ||
* dep array. | ||
*/ | ||
function RefsInEffects() { | ||
const ref = useRefHelper(); | ||
const wrapped = useDeeperRefHelper(); | ||
useEffect(() => { | ||
print(ref.current); | ||
print(wrapped.foo.current); | ||
}); | ||
} | ||
|
||
function useRefHelper() { | ||
return useRef(0); | ||
} | ||
|
||
function useDeeperRefHelper() { | ||
return {foo: useRefHelper()}; | ||
} | ||
|
||
``` | ||
|
||
## Code | ||
|
||
```javascript | ||
import { c as _c } from "react/compiler-runtime"; // @inferEffectDependencies | ||
import { useEffect } from "react"; | ||
import { print } from "shared-runtime"; | ||
|
||
/** | ||
* We never include a .current access in a dep array because it may be a ref access. | ||
* This might over-capture objects that are not refs and happen to have fields named | ||
* current, but that should be a rare case and the result would still be correct | ||
* (assuming the effect is idempotent). In the worst case, you can always write a manual | ||
* dep array. | ||
*/ | ||
function RefsInEffects() { | ||
const $ = _c(3); | ||
const ref = useRefHelper(); | ||
const wrapped = useDeeperRefHelper(); | ||
let t0; | ||
if ($[0] !== ref.current || $[1] !== wrapped.foo.current) { | ||
t0 = () => { | ||
print(ref.current); | ||
print(wrapped.foo.current); | ||
}; | ||
$[0] = ref.current; | ||
$[1] = wrapped.foo.current; | ||
$[2] = t0; | ||
} else { | ||
t0 = $[2]; | ||
} | ||
useEffect(t0, [ref, wrapped.foo]); | ||
} | ||
|
||
function useRefHelper() { | ||
return useRef(0); | ||
} | ||
|
||
function useDeeperRefHelper() { | ||
const $ = _c(2); | ||
const t0 = useRefHelper(); | ||
let t1; | ||
if ($[0] !== t0) { | ||
t1 = { foo: t0 }; | ||
$[0] = t0; | ||
$[1] = t1; | ||
} else { | ||
t1 = $[1]; | ||
} | ||
return t1; | ||
} | ||
|
||
``` | ||
### Eval output | ||
(kind: exception) Fixture not implemented |
27 changes: 27 additions & 0 deletions
27
...ges/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/nonreactive-ref-helper.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// @inferEffectDependencies | ||
import {useEffect} from 'react'; | ||
import {print} from 'shared-runtime'; | ||
|
||
/** | ||
* We never include a .current access in a dep array because it may be a ref access. | ||
* This might over-capture objects that are not refs and happen to have fields named | ||
* current, but that should be a rare case and the result would still be correct | ||
* (assuming the effect is idempotent). In the worst case, you can always write a manual | ||
* dep array. | ||
*/ | ||
function RefsInEffects() { | ||
const ref = useRefHelper(); | ||
const wrapped = useDeeperRefHelper(); | ||
useEffect(() => { | ||
print(ref.current); | ||
print(wrapped.foo.current); | ||
}); | ||
} | ||
|
||
function useRefHelper() { | ||
return useRef(0); | ||
} | ||
|
||
function useDeeperRefHelper() { | ||
return {foo: useRefHelper()}; | ||
} |