Skip to content

Commit

Permalink
Add Scheduling Profiler GK link to Timeline UI for FB build
Browse files Browse the repository at this point in the history
This is a constant source of confusion for FB engineers trying to figure out why Chrome profiling data does not have any React marks.
  • Loading branch information
Brian Vaughn committed Nov 9, 2021
1 parent 0ddd69d commit a2d9f1b
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions packages/react-devtools-timeline/src/Timeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import type {DataResource} from './createDataResourceFromImportedFile';
import type {ViewState} from './types';

import {isInternalFacebookBuild} from 'react-devtools-feature-flags';
import * as React from 'react';
import {
Suspense,
Expand Down Expand Up @@ -90,6 +91,19 @@ const Welcome = ({onFileSelect}: {|onFileSelect: (file: File) => void|}) => (
</a>
(version 18 or newer).
</li>
{isInternalFacebookBuild && (
<li className={styles.WelcomeInstructionsListItem}>
Enable the
<a
className={styles.WelcomeInstructionsListItemLink}
href="https://fburl.com/react-devtools-scheduling-profiler-gk"
rel="noopener noreferrer"
target="_blank">
<code>react_enable_scheduling_profiler</code> GK
</a>
.
</li>
)}
<li className={styles.WelcomeInstructionsListItem}>
Open the "Performance" tab in Chrome and record some performance data.
</li>
Expand Down

0 comments on commit a2d9f1b

Please sign in to comment.