[Fiber] Log Effect and Render Times in Offscreen Commit Phase (#31788)

In #30967 and #30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](6a4b46c)
facebook · Dec 18, 2024 · b34b7cf · b34b7cf
1 parent 332eb42
commit b34b7cf
Show file tree

Hide file tree

Showing 24 changed files with 564 additions and 575 deletions.
diff --git a/compiled-rn/VERSION_NATIVE_FB b/compiled-rn/VERSION_NATIVE_FB
@@ -1 +1 @@
-19.1.0-native-fb-facec3ee-20241217
+19.1.0-native-fb-6a4b46cd-20241217
diff --git a/...iled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js b/...iled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<5f71600380649b875c0a51a31e58dff5>>
+ * @generated SignedSource<<46dacfae87e8ca444b422d58261e7b3e>>
  */
 
 "use strict";
@@ -420,5 +420,5 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.1.0-native-fb-facec3ee-20241217";
+    exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
   })();
diff --git a/...led-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js b/...led-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<a8bc17ffe2d6bec1f415b3bf5659951d>>
+ * @generated SignedSource<<ac23bad20f89258da38fa4a147ede53b>>
  */
 
 "use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-native-fb-facec3ee-20241217";
+exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
diff --git a/...n/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js b/...n/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<a8bc17ffe2d6bec1f415b3bf5659951d>>
+ * @generated SignedSource<<ac23bad20f89258da38fa4a147ede53b>>
  */
 
 "use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.1.0-native-fb-facec3ee-20241217";
+exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
diff --git a/...n/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js b/...n/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js
diff --git a/.../facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js b/.../facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<3983426ab11c7aaa107d81ebca2c5b9f>>
+ * @generated SignedSource<<c34f2186f82f671d1328c7425fe688ea>>
  */
 
 /*
@@ -12361,20 +12361,20 @@ function extractEvents$1(
   }
 }
 for (
-  var i$jscomp$inline_1479 = 0;
-  i$jscomp$inline_1479 < simpleEventPluginEvents.length;
-  i$jscomp$inline_1479++
+  var i$jscomp$inline_1481 = 0;
+  i$jscomp$inline_1481 < simpleEventPluginEvents.length;
+  i$jscomp$inline_1481++
 ) {
-  var eventName$jscomp$inline_1480 =
-      simpleEventPluginEvents[i$jscomp$inline_1479],
-    domEventName$jscomp$inline_1481 =
-      eventName$jscomp$inline_1480.toLowerCase(),
-    capitalizedEvent$jscomp$inline_1482 =
-      eventName$jscomp$inline_1480[0].toUpperCase() +
-      eventName$jscomp$inline_1480.slice(1);
+  var eventName$jscomp$inline_1482 =
+      simpleEventPluginEvents[i$jscomp$inline_1481],
+    domEventName$jscomp$inline_1483 =
+      eventName$jscomp$inline_1482.toLowerCase(),
+    capitalizedEvent$jscomp$inline_1484 =
+      eventName$jscomp$inline_1482[0].toUpperCase() +
+      eventName$jscomp$inline_1482.slice(1);
   registerSimpleEvent(
-    domEventName$jscomp$inline_1481,
-    "on" + capitalizedEvent$jscomp$inline_1482
+    domEventName$jscomp$inline_1483,
+    "on" + capitalizedEvent$jscomp$inline_1484
   );
 }
 registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -15867,16 +15867,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
     0 === i && attemptExplicitHydrationTarget(target);
   }
 };
-var isomorphicReactPackageVersion$jscomp$inline_1722 = React.version;
+var isomorphicReactPackageVersion$jscomp$inline_1724 = React.version;
 if (
-  "19.1.0-native-fb-facec3ee-20241217" !==
-  isomorphicReactPackageVersion$jscomp$inline_1722
+  "19.1.0-native-fb-6a4b46cd-20241217" !==
+  isomorphicReactPackageVersion$jscomp$inline_1724
 )
   throw Error(
     formatProdErrorMessage(
       527,
-      isomorphicReactPackageVersion$jscomp$inline_1722,
-      "19.1.0-native-fb-facec3ee-20241217"
+      isomorphicReactPackageVersion$jscomp$inline_1724,
+      "19.1.0-native-fb-6a4b46cd-20241217"
     )
   );
 ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -15896,24 +15896,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
     null === componentOrElement ? null : componentOrElement.stateNode;
   return componentOrElement;
 };
-var internals$jscomp$inline_2177 = {
+var internals$jscomp$inline_2179 = {
   bundleType: 0,
-  version: "19.1.0-native-fb-facec3ee-20241217",
+  version: "19.1.0-native-fb-6a4b46cd-20241217",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-native-fb-facec3ee-20241217"
+  reconcilerVersion: "19.1.0-native-fb-6a4b46cd-20241217"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_2178 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_2180 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_2178.isDisabled &&
-    hook$jscomp$inline_2178.supportsFiber
+    !hook$jscomp$inline_2180.isDisabled &&
+    hook$jscomp$inline_2180.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_2178.inject(
-        internals$jscomp$inline_2177
+      (rendererID = hook$jscomp$inline_2180.inject(
+        internals$jscomp$inline_2179
       )),
-        (injectedHook = hook$jscomp$inline_2178);
+        (injectedHook = hook$jscomp$inline_2180);
     } catch (err) {}
 }
 exports.createRoot = function (container, options) {
@@ -16007,4 +16007,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
   listenToAllSupportedEvents(container);
   return new ReactDOMHydrationRoot(initialChildren);
 };
-exports.version = "19.1.0-native-fb-facec3ee-20241217";
+exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
diff --git a/...book-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js b/...book-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<350b3d8aa3f45f071bdab61d95033fa5>>
+ * @generated SignedSource<<3bb31c69bf2cc763098612269dfeb872>>
  */
 
 /*
@@ -13006,20 +13006,20 @@ function extractEvents$1(
   }
 }
 for (
-  var i$jscomp$inline_1567 = 0;
-  i$jscomp$inline_1567 < simpleEventPluginEvents.length;
-  i$jscomp$inline_1567++
+  var i$jscomp$inline_1569 = 0;
+  i$jscomp$inline_1569 < simpleEventPluginEvents.length;
+  i$jscomp$inline_1569++
 ) {
-  var eventName$jscomp$inline_1568 =
-      simpleEventPluginEvents[i$jscomp$inline_1567],
-    domEventName$jscomp$inline_1569 =
-      eventName$jscomp$inline_1568.toLowerCase(),
-    capitalizedEvent$jscomp$inline_1570 =
-      eventName$jscomp$inline_1568[0].toUpperCase() +
-      eventName$jscomp$inline_1568.slice(1);
+  var eventName$jscomp$inline_1570 =
+      simpleEventPluginEvents[i$jscomp$inline_1569],
+    domEventName$jscomp$inline_1571 =
+      eventName$jscomp$inline_1570.toLowerCase(),
+    capitalizedEvent$jscomp$inline_1572 =
+      eventName$jscomp$inline_1570[0].toUpperCase() +
+      eventName$jscomp$inline_1570.slice(1);
   registerSimpleEvent(
-    domEventName$jscomp$inline_1569,
-    "on" + capitalizedEvent$jscomp$inline_1570
+    domEventName$jscomp$inline_1571,
+    "on" + capitalizedEvent$jscomp$inline_1572
   );
 }
 registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -16520,16 +16520,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
     0 === i && attemptExplicitHydrationTarget(target);
   }
 };
-var isomorphicReactPackageVersion$jscomp$inline_1812 = React.version;
+var isomorphicReactPackageVersion$jscomp$inline_1814 = React.version;
 if (
-  "19.1.0-native-fb-facec3ee-20241217" !==
-  isomorphicReactPackageVersion$jscomp$inline_1812
+  "19.1.0-native-fb-6a4b46cd-20241217" !==
+  isomorphicReactPackageVersion$jscomp$inline_1814
 )
   throw Error(
     formatProdErrorMessage(
       527,
-      isomorphicReactPackageVersion$jscomp$inline_1812,
-      "19.1.0-native-fb-facec3ee-20241217"
+      isomorphicReactPackageVersion$jscomp$inline_1814,
+      "19.1.0-native-fb-6a4b46cd-20241217"
     )
   );
 ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16549,12 +16549,12 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
     null === componentOrElement ? null : componentOrElement.stateNode;
   return componentOrElement;
 };
-var internals$jscomp$inline_1819 = {
+var internals$jscomp$inline_1821 = {
   bundleType: 0,
-  version: "19.1.0-native-fb-facec3ee-20241217",
+  version: "19.1.0-native-fb-6a4b46cd-20241217",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
-  reconcilerVersion: "19.1.0-native-fb-facec3ee-20241217",
+  reconcilerVersion: "19.1.0-native-fb-6a4b46cd-20241217",
   getLaneLabelMap: function () {
     for (
       var map = new Map(), lane = 1, index$292 = 0;
@@ -16572,16 +16572,16 @@ var internals$jscomp$inline_1819 = {
   }
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_2229 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_2231 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_2229.isDisabled &&
-    hook$jscomp$inline_2229.supportsFiber
+    !hook$jscomp$inline_2231.isDisabled &&
+    hook$jscomp$inline_2231.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_2229.inject(
-        internals$jscomp$inline_1819
+      (rendererID = hook$jscomp$inline_2231.inject(
+        internals$jscomp$inline_1821
       )),
-        (injectedHook = hook$jscomp$inline_2229);
+        (injectedHook = hook$jscomp$inline_2231);
     } catch (err) {}
 }
 exports.createRoot = function (container, options) {
@@ -16675,4 +16675,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
   listenToAllSupportedEvents(container);
   return new ReactDOMHydrationRoot(initialChildren);
 };
-exports.version = "19.1.0-native-fb-facec3ee-20241217";
+exports.version = "19.1.0-native-fb-6a4b46cd-20241217";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		19.1.0-native-fb-facec3ee-20241217
		19.1.0-native-fb-6a4b46cd-20241217