Skip to content

Commit

Permalink
Use modern rendering APIs for attribute-behavior fixture (#27883)
Browse files Browse the repository at this point in the history
The attribute-behavior fixture now uses `createRoot().render()` and
`renderToReadableStream` instead of depdrecated APIs.

This revealed some changes to the snapshots that I annotated for
discussion.

I also added some new tests related to upcoming changes for easier
future diffing.

Also adds support for running the attribute-behavior fixture using Apple
Silicon chips (Apple MBP M-series).

DiffTrain build for commit 9aef5d2.
  • Loading branch information
eps1lon committed Jan 26, 2024
1 parent 39a042c commit b6a6c64
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25607,7 +25607,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-canary-60f190a55-20240126";
var ReactVersion = "18.3.0-canary-9aef5d225-20240126";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9149,7 +9149,7 @@ var devToolsConfig$jscomp$inline_1029 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-60f190a55-20240126",
version: "18.3.0-canary-9aef5d225-20240126",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1205 = {
Expand Down Expand Up @@ -9180,7 +9180,7 @@ var internals$jscomp$inline_1205 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-60f190a55-20240126"
reconcilerVersion: "18.3.0-canary-9aef5d225-20240126"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1206 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9577,7 +9577,7 @@ var devToolsConfig$jscomp$inline_1071 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-60f190a55-20240126",
version: "18.3.0-canary-9aef5d225-20240126",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1246 = {
Expand Down Expand Up @@ -9608,7 +9608,7 @@ var internals$jscomp$inline_1246 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-60f190a55-20240126"
reconcilerVersion: "18.3.0-canary-9aef5d225-20240126"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1247 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-canary-60f190a55-20240126";
var ReactVersion = "18.3.0-canary-9aef5d225-20240126";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -545,4 +545,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-60f190a55-20240126";
exports.version = "18.3.0-canary-9aef5d225-20240126";
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-60f190a55-20240126";
exports.version = "18.3.0-canary-9aef5d225-20240126";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
60f190a55948a7512d4e2a336f03b45fd38d6a80
9aef5d225b489ceeba753c5c86b236259baf816c

0 comments on commit b6a6c64

Please sign in to comment.