Skip to content

Commit

Permalink
[FB] disable legacy mode in modern build
Browse files Browse the repository at this point in the history
Disables legacy mode in www-modern and removes the entrypoint hack in tests since we gate legacy mode tests now

Additionally disables test utils because this relies on legacy mode.

Additionally gates react-test-renderer test for unstable_Scope because it seems to also rely on legacy roots.
  • Loading branch information
gnoff committed Apr 3, 2024
1 parent 8f55a6a commit bf5292b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/react-dom/src/__tests__/ReactDOMRoot-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('ReactDOMRoot', () => {
expect(container.textContent).toEqual('Hi');
});

// @gate !classic || !__DEV__
// @gate !www || !__DEV__
it('warns if you import createRoot from react-dom', async () => {
expect(() => ReactDOM.createRoot(container)).toErrorDev(
'You are importing createRoot from "react-dom" which is not supported. ' +
Expand All @@ -58,7 +58,7 @@ describe('ReactDOMRoot', () => {
);
});

// @gate !classic || !__DEV__
// @gate !www || !__DEV__
it('warns if you import hydrateRoot from react-dom', async () => {
expect(() => ReactDOM.hydrateRoot(container, null)).toErrorDev(
'You are importing hydrateRoot from "react-dom" which is not supported. ' +
Expand Down
3 changes: 2 additions & 1 deletion packages/react/index.modern.fb.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export {
unstable_Activity,
unstable_Scope,
unstable_SuspenseList,
unstable_TracingMarker,
unstable_getCacheForType,
unstable_useCacheRefresh,
unstable_useMemoCache,
Expand All @@ -48,10 +49,10 @@ export {
useLayoutEffect,
useMemo,
useOptimistic,
useSyncExternalStore,
useReducer,
useRef,
useState,
useSyncExternalStore,
useTransition,
useActionState,
version,
Expand Down
5 changes: 0 additions & 5 deletions scripts/jest/setupHostConfigs.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ function resolveEntryFork(resolvedEntry, isFBBundle) {
// .js

if (isFBBundle) {
if (__EXPERIMENTAL__) {
// We can't currently use the true modern entry point because too many tests fail.
// TODO: Fix tests to not use ReactDOM.render or gate them. Then we can remove this.
return resolvedEntry;
}
const resolvedFBEntry = resolvedEntry.replace(
'.js',
__EXPERIMENTAL__ ? '.modern.fb.js' : '.classic.fb.js'
Expand Down

0 comments on commit bf5292b

Please sign in to comment.