Skip to content

Commit

Permalink
fix incorrect insertion order of stylesheets (#28108)
Browse files Browse the repository at this point in the history 
## Summary

In the precendences Map every key is prefixed with `p`. This fixes one
case where this is missing.

## How did you test this change?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->

DiffTrain build for [7636126](7636126)
  • Loading branch information
@gnoff
gnoff committed Jan 26, 2024
1 parent bd16b96 commit c53cad6
Show file tree
Hide file tree
Showing 13 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
85b296e9b6ded4accd9ec3389297f95091fb1ac0
763612647ceb66d95f728af896ca5e18a8181db8
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-www-classic-af9ffe5b";
var ReactVersion = "18.3.0-www-classic-a55e720b";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}

var ReactVersion = "18.3.0-www-modern-2a25f03a";
var ReactVersion = "18.3.0-www-modern-606c88be";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35045,7 +35045,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-classic-463bb300";
var ReactVersion = "18.3.0-www-classic-b3425480";

function createPortal$1(
children,
Expand Down Expand Up @@ -45612,7 +45612,7 @@ if (__DEV__) {
precedences.set("last", instance);
}

precedences.set(precedence, instance);
precedences.set("p" + precedence, instance);
this.count++;
var onComplete = onUnsuspend.bind(this);
instance.addEventListener("load", onComplete);
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34866,7 +34866,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-modern-6f317449";
var ReactVersion = "18.3.0-www-modern-1fddac1a";

function createPortal$1(
children,
Expand Down Expand Up @@ -46098,7 +46098,7 @@ if (__DEV__) {
precedences.set("last", instance);
}

precedences.set(precedence, instance);
precedences.set("p" + precedence, instance);
this.count++;
var onComplete = onUnsuspend.bind(this);
instance.addEventListener("load", onComplete);
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15830,7 +15830,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -16641,7 +16641,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1801 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bf108a56",
version: "18.3.0-www-classic-155e9f59",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2147 = {
Expand Down Expand Up @@ -16671,7 +16671,7 @@ var internals$jscomp$inline_2147 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-bf108a56"
reconcilerVersion: "18.3.0-www-classic-155e9f59"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2148 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17008,4 +17008,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-bf108a56";
exports.version = "18.3.0-www-classic-155e9f59";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-prod.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16056,7 +16056,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -16164,7 +16164,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1760 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-d5b75bf8",
version: "18.3.0-www-modern-ac114578",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2111 = {
Expand Down Expand Up @@ -16195,7 +16195,7 @@ var internals$jscomp$inline_2111 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-d5b75bf8"
reconcilerVersion: "18.3.0-www-modern-ac114578"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2112 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16460,4 +16460,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-d5b75bf8";
exports.version = "18.3.0-www-modern-ac114578";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16599,7 +16599,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -17410,7 +17410,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1886 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-4b1d2c60",
version: "18.3.0-www-classic-f5d53ab6",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -17454,7 +17454,7 @@ var devToolsConfig$jscomp$inline_1886 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-4b1d2c60"
reconcilerVersion: "18.3.0-www-classic-f5d53ab6"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -17778,7 +17778,7 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-4b1d2c60";
exports.version = "18.3.0-www-classic-f5d53ab6";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16819,7 +16819,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -16927,7 +16927,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1845 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-2a25f03a",
version: "18.3.0-www-modern-606c88be",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16972,7 +16972,7 @@ var devToolsConfig$jscomp$inline_1845 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-2a25f03a"
reconcilerVersion: "18.3.0-www-modern-606c88be"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -17224,7 +17224,7 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-2a25f03a";
exports.version = "18.3.0-www-modern-606c88be";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35669,7 +35669,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-classic-78856bf2";
var ReactVersion = "18.3.0-www-classic-b09ceb48";

function createPortal$1(
children,
Expand Down Expand Up @@ -46368,7 +46368,7 @@ if (__DEV__) {
precedences.set("last", instance);
}

precedences.set(precedence, instance);
precedences.set("p" + precedence, instance);
this.count++;
var onComplete = onUnsuspend.bind(this);
instance.addEventListener("load", onComplete);
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35490,7 +35490,7 @@ if (__DEV__) {
return root;
}

var ReactVersion = "18.3.0-www-modern-64c7bec9";
var ReactVersion = "18.3.0-www-modern-21fe6455";

function createPortal$1(
children,
Expand Down Expand Up @@ -46854,7 +46854,7 @@ if (__DEV__) {
precedences.set("last", instance);
}

precedences.set(precedence, instance);
precedences.set("p" + precedence, instance);
this.count++;
var onComplete = onUnsuspend.bind(this);
instance.addEventListener("load", onComplete);
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16159,7 +16159,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -16970,7 +16970,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1806 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-af9ffe5b",
version: "18.3.0-www-classic-a55e720b",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2159 = {
Expand Down Expand Up @@ -17000,7 +17000,7 @@ var internals$jscomp$inline_2159 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-af9ffe5b"
reconcilerVersion: "18.3.0-www-classic-a55e720b"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2160 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17488,4 +17488,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-classic-af9ffe5b";
exports.version = "18.3.0-www-classic-a55e720b";
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16439,7 +16439,7 @@ function insertStylesheetIntoRoot(root, resource) {
node = nodes.getAttribute("data-precedence");
i = precedences.get("p" + node) || last;
i === last && precedences.set("last", nodes);
precedences.set(node, nodes);
precedences.set("p" + node, nodes);
this.count++;
last = onUnsuspend.bind(this);
nodes.addEventListener("load", last);
Expand Down Expand Up @@ -16547,7 +16547,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1765 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-f302a037",
version: "18.3.0-www-modern-1e455221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2122 = {
Expand Down Expand Up @@ -16578,7 +16578,7 @@ var internals$jscomp$inline_2122 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-f302a037"
reconcilerVersion: "18.3.0-www-modern-1e455221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2123 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16993,4 +16993,4 @@ exports.useFormState = function () {
exports.useFormStatus = function () {
throw Error(formatProdErrorMessage(248));
};
exports.version = "18.3.0-www-modern-f302a037";
exports.version = "18.3.0-www-modern-1e455221";

0 comments on commit c53cad6

Please sign in to comment.