Skip to content

Commit

Permalink
Use explicit git hash length in version string (#30318)
Browse files Browse the repository at this point in the history
This avoids potential differences between Git versions.

Having a guarantee unique hash isn't neccessary as it's just
informational and we have the date in the version string as well.
  • Loading branch information
kassens authored Jul 11, 2024
1 parent a09950e commit d09484c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions scripts/rollup/build-all-release-channels.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ const {
// Runs the build script for both stable and experimental release channels,
// by configuring an environment variable.

const sha = String(
spawnSync('git', ['show', '-s', '--no-show-signature', '--format=%h']).stdout
).trim();
const sha = String(spawnSync('git', ['rev-parse', 'HEAD']).stdout).slice(0, 8);

let dateString = String(
spawnSync('git', [
Expand Down

0 comments on commit d09484c

Please sign in to comment.