Skip to content

Commit

Permalink
Revert "Cleanup enableSyncDefaultUpdate flag (#26236)" (#26528)
Browse files Browse the repository at this point in the history
This reverts commit b2ae9dd.

While the feature flag is fully rolled out, these tests are also testing
behavior set with an unstable flag on root, which for now we want to
preserve.

Not sure if there's a better way then adding a dynamic feature flag to
the www build?

DiffTrain build for commit da94e8b.
  • Loading branch information
kassens committed Apr 4, 2023
1 parent 08375e6 commit ea9bc44
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23482,6 +23482,8 @@ function createHostRootFiber(
}

if (
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
// Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
Expand Down Expand Up @@ -23882,7 +23884,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-0700dd50b-20230404";
var ReactVersion = "18.3.0-next-da94e8b24-20230404";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8683,7 +8683,7 @@ var devToolsConfig$jscomp$inline_1028 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1220 = {
Expand Down Expand Up @@ -8714,7 +8714,7 @@ var internals$jscomp$inline_1220 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1221 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9108,7 +9108,7 @@ var devToolsConfig$jscomp$inline_1070 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1261 = {
Expand Down Expand Up @@ -9139,7 +9139,7 @@ var internals$jscomp$inline_1261 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1262 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-next-0700dd50b-20230404";
var ReactVersion = "18.3.0-next-da94e8b24-20230404";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-0700dd50b-20230404";
exports.version = "18.3.0-next-da94e8b24-20230404";
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-0700dd50b-20230404";
exports.version = "18.3.0-next-da94e8b24-20230404";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0700dd50bda98f5ee86f2e3adfe5e9906ed1e8e3
da94e8b24a3f31a3e805f9bf6bba73055aad9d41
Original file line number Diff line number Diff line change
Expand Up @@ -26716,6 +26716,8 @@ function createHostRootFiber(
}

if (
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
// Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
Expand Down Expand Up @@ -27175,7 +27177,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-0700dd50b-20230404";
var ReactVersion = "18.3.0-next-da94e8b24-20230404";

function createPortal$1(
children,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9554,7 +9554,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1052 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -9596,7 +9596,7 @@ var internals$jscomp$inline_1297 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1298 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10262,7 +10262,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1130 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -10317,7 +10317,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
});
exports.createPortal = function (children, containerTag) {
return createPortal$1(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27239,6 +27239,8 @@ function createHostRootFiber(
}

if (
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
// Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
Expand Down Expand Up @@ -27698,7 +27700,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-0700dd50b-20230404";
var ReactVersion = "18.3.0-next-da94e8b24-20230404";

function createPortal$1(
children,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9810,7 +9810,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1107 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -9852,7 +9852,7 @@ var internals$jscomp$inline_1359 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1360 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10518,7 +10518,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1185 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-0700dd50b-20230404",
version: "18.3.0-next-da94e8b24-20230404",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -10573,7 +10573,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0700dd50b-20230404"
reconcilerVersion: "18.3.0-next-da94e8b24-20230404"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
computeComponentStackForErrorReporting: function (reactTag) {
Expand Down

0 comments on commit ea9bc44

Please sign in to comment.