ESLint upgrade to use hermes-eslint (#25915)

Hermes parser is the preferred parser for Flow code going forward. We need to upgrade to this parser to support new Flow syntax like function `this` context type annotations or `ObjectType['prop']` syntax. Unfortunately, there's quite a few upgrades here to make it work somehow (dependencies between the changes) - ~Upgrade `eslint` to `8.*`~ reverted this as the React eslint plugin tests depend on the older version and there's a [yarn bug](yarnpkg/yarn#6285) that prevents `devDependencies` and `peerDependencies` to different versions. - Remove `eslint-config-fbjs` preset dependency and inline the rules, imho this makes it a lot clearer what the rules are. - Remove the turned off `jsx-a11y/*` rules and it's dependency instead of inlining those from the `fbjs` config. - Update parser and dependency from `babel-eslint` to `hermes-eslint`. - `ft-flow/no-unused-expressions` rule replaces `no-unused-expressions` which now allows standalone type asserts, e.g. `(foo: number);` - Bunch of globals added to the eslint config - Disabled `no-redeclare`, seems like the eslint upgrade started making this more precise and warn against re-defined globals like `__EXPERIMENTAL__` (in rollup scripts) or `fetch` (when importing fetch from node-fetch). - Minor lint fixes like duplicate keys in objects. DiffTrain build for [2b1fb91](2b1fb91) [View git log for this commit](https://github.com/facebook/react/commits/2b1fb91a55deb9b7b60452cb57184c2f182a42fd)
facebook · Dec 20, 2022 · ecbf597 · ecbf597
1 parent 40ea970
commit ecbf597
Show file tree

Hide file tree

Showing 30 changed files with 78 additions and 56 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-fabef7a6b71798fe2477720e59d090a0e74e0009
+2b1fb91a55deb9b7b60452cb57184c2f182a42fd
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-fabef7a6b71798fe2477720e59d090a0e74e0009
+2b1fb91a55deb9b7b60452cb57184c2f182a42fd
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-fabef7a6b-20221215";
+exports.version = "18.3.0-www-classic-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-fabef7a6b-20221215";
+exports.version = "18.3.0-www-modern-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-fabef7a6b-20221215";
+exports.version = "18.3.0-www-classic-2b1fb91a5-20221220";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-fabef7a6b-20221215";
+exports.version = "18.3.0-www-modern-2b1fb91a5-20221220";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -2926,7 +2926,7 @@ function getInstanceFromNode(node) {
 }
 function preparePortalMount(portalInstance) {
   // noop
-}
+} // eslint-disable-next-line no-undef
 
 var ReactCurrentDispatcher = ReactSharedInternals.ReactCurrentDispatcher;
 var prefix;
@@ -24093,6 +24093,7 @@ function getExecutionContext() {
   return executionContext;
 }
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -2923,7 +2923,7 @@ function getInstanceFromNode(node) {
 }
 function preparePortalMount(portalInstance) {
   // noop
-}
+} // eslint-disable-next-line no-undef
 
 var ReactCurrentDispatcher = ReactSharedInternals.ReactCurrentDispatcher;
 var prefix;
@@ -23782,6 +23782,7 @@ function getExecutionContext() {
   return executionContext;
 }
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9827,7 +9827,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-classic-fabef7a6b-20221215",
+    version: "18.3.0-www-classic-2b1fb91a5-20221220",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1338 = {
@@ -9858,7 +9858,7 @@ var internals$jscomp$inline_1338 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1339 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9494,7 +9494,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-modern-fabef7a6b-20221215",
+    version: "18.3.0-www-modern-2b1fb91a5-20221220",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1329 = {
@@ -9525,7 +9525,7 @@ var internals$jscomp$inline_1329 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1330 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -6607,10 +6607,10 @@ function getOffsets(outerNode) {
   // https://bugzilla.mozilla.org/show_bug.cgi?id=208427
 
   try {
-    /* eslint-disable no-unused-expressions */
+    /* eslint-disable ft-flow/no-unused-expressions */
     anchorNode.nodeType;
     focusNode.nodeType;
-    /* eslint-enable no-unused-expressions */
+    /* eslint-enable ft-flow/no-unused-expressions */
   } catch (e) {
     return null;
   }
@@ -39076,6 +39076,7 @@ function discreteUpdates(fn, a, b, c, d) {
   }
 } // Overload the definition to the two valid signatures.
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {
@@ -42642,7 +42643,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
 
 function createPortal(
   children,

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -9940,10 +9940,10 @@ function getOffsets(outerNode) {
   // https://bugzilla.mozilla.org/show_bug.cgi?id=208427
 
   try {
-    /* eslint-disable no-unused-expressions */
+    /* eslint-disable ft-flow/no-unused-expressions */
     anchorNode.nodeType;
     focusNode.nodeType;
-    /* eslint-enable no-unused-expressions */
+    /* eslint-enable ft-flow/no-unused-expressions */
   } catch (e) {
     return null;
   }
@@ -38800,6 +38800,7 @@ function discreteUpdates(fn, a, b, c, d) {
   }
 } // Overload the definition to the two valid signatures.
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {
@@ -42366,7 +42367,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
 
 function createPortal(
   children,

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15580,7 +15580,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1770 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-fabef7a6b-20221215",
+  version: "18.3.0-www-classic-2b1fb91a5-20221220",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2157 = {
@@ -15610,7 +15610,7 @@ var internals$jscomp$inline_2157 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2158 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15852,4 +15852,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-fabef7a6b-20221215";
+exports.version = "18.3.0-next-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -15141,7 +15141,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1738 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-fabef7a6b-20221215",
+  version: "18.3.0-www-modern-2b1fb91a5-20221220",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2132 = {
@@ -15172,7 +15172,7 @@ var internals$jscomp$inline_2132 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2133 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15360,4 +15360,4 @@ exports.unstable_flushControlled = function(fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-fabef7a6b-20221215";
+exports.version = "18.3.0-next-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -16352,7 +16352,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1844 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-fabef7a6b-20221215",
+  version: "18.3.0-www-classic-2b1fb91a5-20221220",
   rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -16396,7 +16396,7 @@ var devToolsConfig$jscomp$inline_1844 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 });
 assign(Internals, {
   ReactBrowserEventEmitter: {
@@ -16625,7 +16625,7 @@ exports.unstable_renderSubtreeIntoContainer = function(
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-fabef7a6b-20221215";
+exports.version = "18.3.0-next-2b1fb91a5-20221220";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -15903,7 +15903,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1812 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-fabef7a6b-20221215",
+  version: "18.3.0-www-modern-2b1fb91a5-20221220",
   rendererPackageName: "react-dom"
 };
 (function(internals) {
@@ -15948,7 +15948,7 @@ var devToolsConfig$jscomp$inline_1812 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-fabef7a6b-20221215"
+  reconcilerVersion: "18.3.0-next-2b1fb91a5-20221220"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function(children, container) {
@@ -16123,7 +16123,7 @@ exports.unstable_flushControlled = function(fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-fabef7a6b-20221215";
+exports.version = "18.3.0-next-2b1fb91a5-20221220";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-classic-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");

diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-modern-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");

diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -3633,4 +3633,4 @@ exports.renderToString = function(children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-classic-fabef7a6b-20221215";
+exports.version = "18.3.0-www-classic-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js
@@ -3546,4 +3546,4 @@ exports.renderToString = function(children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-modern-fabef7a6b-20221215";
+exports.version = "18.3.0-www-modern-2b1fb91a5-20221220";
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
@@ -6564,10 +6564,10 @@ function getOffsets(outerNode) {
   // https://bugzilla.mozilla.org/show_bug.cgi?id=208427
 
   try {
-    /* eslint-disable no-unused-expressions */
+    /* eslint-disable ft-flow/no-unused-expressions */
     anchorNode.nodeType;
     focusNode.nodeType;
-    /* eslint-enable no-unused-expressions */
+    /* eslint-enable ft-flow/no-unused-expressions */
   } catch (e) {
     return null;
   }
@@ -28204,6 +28204,7 @@ function discreteUpdates(fn, a, b, c, d) {
   }
 } // Overload the definition to the two valid signatures.
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {
@@ -31167,7 +31168,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
 
 function createPortal(
   children,

diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js
@@ -9174,10 +9174,10 @@ function getOffsets(outerNode) {
   // https://bugzilla.mozilla.org/show_bug.cgi?id=208427
 
   try {
-    /* eslint-disable no-unused-expressions */
+    /* eslint-disable ft-flow/no-unused-expressions */
     anchorNode.nodeType;
     focusNode.nodeType;
-    /* eslint-enable no-unused-expressions */
+    /* eslint-enable ft-flow/no-unused-expressions */
   } catch (e) {
     return null;
   }
@@ -35492,6 +35492,7 @@ function discreteUpdates(fn, a, b, c, d) {
   }
 } // Overload the definition to the two valid signatures.
 // Warning, this opts-out of checking the function body.
+// eslint-disable-next-line no-unused-vars
 
 // eslint-disable-next-line no-redeclare
 function flushSync(fn) {
@@ -38455,7 +38456,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-fabef7a6b-20221215";
+var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
 
 function createPortal(
   children,