Skip to content

Commit

Permalink
Don't modify keyPath until right before recursive renderNode call (#2…
Browse files Browse the repository at this point in the history
…7366)

Currently, if a component suspends, the keyPath has already been
modified to include the identity of the component itself; the path is
set before the component body is called (akin to the begin phase in
Fiber). An accidental consequence is that when the promise resolves and
component is retried, the identity gets appended to the keyPath again,
leading to a duplicate node in the path.

To address this, we should only modify contexts after any code that may
suspend. For maximum safety, this should occur as late as possible:
right before the recursive renderNode call, before the children are
rendered.

I did not add a test yet because there's no feature that currently
observes it, but I do have tests in my other WIP PR for useFormState:
#27321

DiffTrain build for [d07921e](d07921e)
  • Loading branch information
acdlite committed Sep 13, 2023
1 parent f527fd1 commit ed7966e
Show file tree
Hide file tree
Showing 8 changed files with 654 additions and 230 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7a3cb8f9cf43591afc74722ece9e3216ccc98128
d07921eeda62613bfcf52ecdb66322db26393567
Loading

0 comments on commit ed7966e

Please sign in to comment.