Update

[ghstack-poisoned]
facebook · Sep 6, 2024 · fbd1763 · fbd1763
1 parent a085e4c
commit fbd1763
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 18 deletions.
diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
@@ -222,6 +222,8 @@ const EnvironmentConfigSchema = z.object({
    */
   enableUseTypeAnnotations: z.boolean().default(false),
 
+  enablePropagateDepsInHIR: z.boolean().default(true),
+
   /**
    * Enables inference of optional dependency chains. Without this flag
    * a property chain such as `props?.items?.foo` will infer as a dep on

diff --git a/...rc/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.expect.md b/...rc/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 function Component(props) {
   const data = useMemo(() => {
     return props?.items.edges?.nodes.map();
@@ -15,7 +15,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 function Component(props) {
   const $ = _c(4);
 

diff --git a/...-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.js b/...-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-as-memo-dep.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 function Component(props) {
   const data = useMemo(() => {
     return props?.items.edges?.nodes.map();

diff --git a/...compiler/optional-member-expression-inverted-optionals-parallel-paths.expect.md b/...compiler/optional-member-expression-inverted-optionals-parallel-paths.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {
@@ -19,7 +19,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import { ValidateMemoization } from "shared-runtime";
 function Component(props) {
   const $ = _c(2);

diff --git a/...tests__/fixtures/compiler/optional-member-expression-inverted-optionals-parallel-paths.js b/...tests__/fixtures/compiler/optional-member-expression-inverted-optionals-parallel-paths.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {

diff --git a/...ixtures/compiler/optional-member-expression-single-with-unconditional.expect.md b/...ixtures/compiler/optional-member-expression-single-with-unconditional.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {
@@ -19,7 +19,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import { ValidateMemoization } from "shared-runtime";
 function Component(props) {
   const $ = _c(7);

diff --git a/...r/src/__tests__/fixtures/compiler/optional-member-expression-single-with-unconditional.js b/...r/src/__tests__/fixtures/compiler/optional-member-expression-single-with-unconditional.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {

diff --git a/...ler/src/__tests__/fixtures/compiler/optional-member-expression-single.expect.md b/...ler/src/__tests__/fixtures/compiler/optional-member-expression-single.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {
@@ -18,7 +18,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import { ValidateMemoization } from "shared-runtime";
 function Component(props) {
   const $ = _c(7);

diff --git a/...lugin-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-single.js b/...lugin-react-compiler/src/__tests__/fixtures/compiler/optional-member-expression-single.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {

diff --git a/...ixtures/compiler/optional-member-expression-with-conditional-optional.expect.md b/...ixtures/compiler/optional-member-expression-with-conditional-optional.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {
@@ -23,7 +23,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import { ValidateMemoization } from "shared-runtime";
 function Component(props) {
   const $ = _c(9);

diff --git a/...r/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional-optional.js b/...r/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional-optional.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {

diff --git a/...tests__/fixtures/compiler/optional-member-expression-with-conditional.expect.md b/...tests__/fixtures/compiler/optional-member-expression-with-conditional.expect.md
@@ -2,7 +2,7 @@
 ## Input
 
 ```javascript
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {
@@ -23,7 +23,7 @@ function Component(props) {
 ## Code
 
 ```javascript
-import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+import { c as _c } from "react/compiler-runtime"; // @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import { ValidateMemoization } from "shared-runtime";
 function Component(props) {
   const $ = _c(9);

diff --git a/...t-compiler/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional.js b/...t-compiler/src/__tests__/fixtures/compiler/optional-member-expression-with-conditional.js
@@ -1,4 +1,4 @@
-// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies
+// @validatePreserveExistingMemoizationGuarantees @enableOptionalDependencies @enablePropagateDepsInHIR:false
 import {ValidateMemoization} from 'shared-runtime';
 function Component(props) {
   const data = useMemo(() => {