-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevTools: Show Source should point to render
, not constructor
#16749
Labels
Comments
Basically this should be backported: https://github.com/facebook/react-devtools/blob/v3.3.2/shells/webextension/src/panel.js#L73-L83 to here react/packages/react-devtools-extensions/src/utils.js Lines 16 to 19 in b438699
I hope this simplification was not intentional. |
theKashey
changed the title
DevTools: Show Source should point to
DevTools: Show Source should point to Sep 11, 2019
render
, not contructor
render
, not constructor
PRs are welcome. |
theKashey
added a commit
to theKashey/react
that referenced
this issue
Sep 12, 2019
bvaughn
pushed a commit
that referenced
this issue
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug. Regression to be more concrete - facebook/react-devtools#1191
What is the current behavior?
Show Source points to a Function Component body, and Class Component constructor.
What is the expected behavior?
In both cases, you should see "render" methods, class constructor is never something you might want to jump straight into. It was working in this expected way in a previous version of Dev Tools.
Why this is an issue?
Well, until React-Hot-Loader is not 100% deprecated, "Show Source" would not work at all, as long as it (and not only it -
mobx
would do the same) is wrapping class constructor, however keepingrender
untouched.The text was updated successfully, but these errors were encountered: