-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React 19] Fiber is missing a debug information #29092
Comments
@sebmarkbage Hi, I see you made the changes in the related code. You mentioned in the commit that the change is only for the server rendering, but now any debug information is missing for the client rendering components. |
This seems to have been removed with #29092 |
This was removed in #28265, see that PR for the reasoning. The internal fiber structure is internal and will break between any release. |
@rickhanlonii thank you for your answer, I understand the Fiber structure can be changed, but this change also broke the way DevTools displays the source. The lazy approach getting the source returns different information. Before this change, the source in DevTools pointed to the place that used the Component in the project source file. Now it will point to the place that defines the component in the compiled output of the build tool. For example, before, if I had this code:
The source for But now the DevTools point the source to one of the runtime chunk files of the build tool (I'm using Vite so it shows like this |
The change to the source is expected I think, but breaking 18 isn't. Yeah please file a issue specific for that cc @hoxyq |
For the past few weeks I've heard from many people the same feedback on the source location stuff, that people actually want to see the JSX part and not the actual component declaration, which totally makes sense to me. We would need to change the UI in DevTools for it though, because we have different features relying on the same source information. I will follow-up in #29164. |
Summary
In React 18, Fiber exposed
_debugSource
In React 19 (19.0.0-rc-915b914b3a-20240515) this was changed to
_debugInfo
but the value is alwaynull
The text was updated successfully, but these errors were encountered: