Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactLink still using React.PropTypes. #9755

Closed
lrojas94 opened this issue May 23, 2017 · 2 comments
Closed

ReactLink still using React.PropTypes. #9755

lrojas94 opened this issue May 23, 2017 · 2 comments
Assignees
@flarnie
Milestone
15.6

Comments

@lrojas94
Copy link

lrojas94 commented May 23, 2017 •
edited
Loading

Do you want to request a feature or report a bug?
BUG

What is the current behavior?
React is using React.PropTypes even though it states it's going to be deprecated.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).
https://github.com/facebook/react/blob/15-stable/src/addons/link/ReactLink.js#L62

What is the expected behavior?
Should use PropTypes from the prop-types package.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
15.5.4
@flarnie flarnie self-assigned this May 23, 2017
@flarnie flarnie added this to the 15.6 milestone May 23, 2017
flarnie added a commit to flarnie/react that referenced this issue May 23, 2017
@flarnie
Remove stray reference to React.PropTypes in ReactLink
959c84d 
**what is the change?:**
It looks like we missed updating this callsite in facebook@12a96b9

**why make this change?:**
We are deprecating the `React.PropTypes` syntax and splitting that functionality into [a separate module](facebook@12a96b9).
@acdlite please correct me if there is a reason we left this here.

**test plan:**
`yarn test`

**issue:**
facebook#9755
@flarnie flarnie mentioned this issue May 23, 2017
Merged
flarnie added a commit that referenced this issue May 24, 2017
@flarnie
Remove stray reference to React.PropTypes in ReactLink (#9757)
d97317e 
**what is the change?:**
It looks like we missed updating this callsite in 12a96b9

**why make this change?:**
We are deprecating the `React.PropTypes` syntax and splitting that functionality into [a separate module](12a96b9).
@acdlite please correct me if there is a reason we left this here.

**test plan:**
`yarn test`

**issue:**
#9755
@flarnie
Copy link
Contributor

flarnie commented May 24, 2017

Thanks for reporting this @lrojas94!

We might want to do a release of that add-on via npm. I can look into that.

flarnie added a commit to flarnie/react that referenced this issue Jun 7, 2017
@flarnie
Remove stray reference to React.PropTypes in ReactLink (facebook#9757)
80e87c4 
**what is the change?:**
It looks like we missed updating this callsite in facebook@12a96b9

**why make this change?:**
We are deprecating the `React.PropTypes` syntax and splitting that functionality into [a separate module](facebook@12a96b9).
@acdlite please correct me if there is a reason we left this here.

**test plan:**
`yarn test`

**issue:**
facebook#9755
@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

We fixed this in #9766. Will be out in next release.

@gaearon gaearon closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flarnie flarnie

Labels
None yet
Projects
None yet
Milestone
15.6
Development

No branches or pull requests
3 participants
@gaearon @flarnie @lrojas94