Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Markdown table from attribute fixture #10595

Merged
merged 4 commits into from
Sep 6, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 2, 2017

This makes the "Save" button generate the table file.
I checked in the table that it produces.

https://github.com/gaearon/react/blob/c367e1499de2ccb6a401a3e9a2b4d531b831dcff/fixtures/attribute-behavior/AttributeTableSnapshot.md

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 2, 2017

@bvaughn I added a "fast mode" (http://localhost:3000/?fast) which should help.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 2, 2017

+13,566 🤔 someone's trying to get a head start on "top oss contributor" for next year 🤣

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gaearon gaearon merged commit faf186b into facebook:master Sep 6, 2017
@gaearon gaearon deleted the table-md branch September 6, 2017 15:08
flarnie pushed a commit to flarnie/react that referenced this pull request Sep 8, 2017
* Generate Markdown table

* Check in generated table

* Add fast mode

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants