Remove View.propTypes RN deprecation workaround #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
reviewed
Sep 12, 2017
There was a problem hiding this comment.
This change is fine. We should do it at some point. Unfortunately, new references to View.propTypes have been added to fbsource, despite the deprecation warning
Do you mind holding off a bit before merging this? Maybe we can revisit it in a week or two. I've got a lot of things in the air with the event types stuff and then there's other changes like #10680 that should probably be merged in ASAP. (And this is just a cleanup.)
|
Sure. |
bvaughn
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we don't need it anymore?
Based on
I haven't actually tested.