-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for createHTMLDocument API specific to IE11 #10921
Merged
gaearon
merged 2 commits into
facebook:master
from
leidegre:react-dom-development-ie11-fix
Sep 28, 2017
Merged
Fix for createHTMLDocument API specific to IE11 #10921
gaearon
merged 2 commits into
facebook:master
from
leidegre:react-dom-development-ie11-fix
Sep 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createHTMLDocument API title parameter is not optional in IE while other browsers don't care IE11 will throw if an argument is not passed. This only impacts react.dom.development not react.dom.production.
Looks great. Thanks! |
This was referenced Sep 29, 2017
This was referenced Oct 14, 2017
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
This was referenced Feb 2, 2018
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createHTMLDocument API title parameter is not optional in IE while other browsers don't care IE11 will throw if an argument is not passed. This only impacts react.dom.development not react.dom.production.
Fixes issue #10865
Before submitting a pull request, please make sure the following is done:
master
.npm test
).npm run prettier
).npm run lint
).npm run flow
).