Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let UMD create extraneous global variables #10935

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 28, 2017

Fixes #10909.

From the doc on assumeFunctionWrapper:

Enable additional optimizations based on the assumption that the output will be wrapped with a function wrapper. This flag is used to indicate that "global" declarations will not actually be global but instead isolated to the compilation unit. This enables additional optimizations.

They actually are global in UMD builds so this flag should not have been set.

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit e4f6462

https://deploy-preview-10935--reactjs.netlify.com

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. This all looks good to me.

@gaearon gaearon merged commit 366c4bb into facebook:master Sep 29, 2017
@gaearon gaearon mentioned this pull request Oct 3, 2017
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants