Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjacent text nodes in SSR should have comments between them despite components #11109

Merged
merged 4 commits into from
Oct 5, 2017
Merged

Adjacent text nodes in SSR should have comments between them despite components #11109

merged 4 commits into from
Oct 5, 2017

Commits on Oct 5, 2017

  1. Add a failing test for text nodes within components

    @gaearon
    gaearon committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    6a60b5d View commit details
    Browse the repository at this point in the history

  2. Reset the text node flag only when emitting tags 

    This ensures we don't reset it when we exit components that return strings.
    @gaearon
    gaearon committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    fd4d0a7 View commit details
    Browse the repository at this point in the history

  3. Add a failing test for a more complex tree

    @gaearon
    gaearon committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    0f5910b View commit details
    Browse the repository at this point in the history

  4. Also reset text flag when emitting a footer 

    This fixes the {'a'}</div>{'b'} case and prevents an unnecessary comment before 'b'.
    @gaearon
    gaearon committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    cd2df6c View commit details
    Browse the repository at this point in the history