-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constructor error message #11395
Merged
gaearon
merged 9 commits into
facebook:master
from
dylanapplegate:constructor-error-message
Nov 1, 2017
Merged
Constructor error message #11395
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0ef3e10
Constructor test and fix complete
1034a19
Linters and prettier run
03dc163
Remove unnecessary checks
e9a0574
Update error message
51c5c71
Updat unit test
186062f
prettier
d739f86
Tweak the check to be more specific
gaearon 0593cce
Move tests to ReactCompositeComponent-test
884e1b4
add error call count and remove line
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1500,4 +1500,45 @@ describe('ReactCompositeComponent', () => { | |
ReactTestUtils.renderIntoDocument(<Component />); | ||
expect(mockArgs.length).toEqual(0); | ||
}); | ||
|
||
it('should return a meaningful warning when constructor is returned', () => { | ||
spyOn(console, 'error'); | ||
class RenderTextInvalidConstructor extends React.Component { | ||
constructor(props) { | ||
super(props); | ||
return {something: false}; | ||
} | ||
|
||
render() { | ||
return <div />; | ||
} | ||
} | ||
|
||
expect(function() { | ||
ReactTestUtils.renderIntoDocument(<RenderTextInvalidConstructor />); | ||
}).toThrow(); | ||
|
||
const error = console.error.calls.mostRecent().args[0]; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: let's remove this newline |
||
expectDev(error).toBe( | ||
'Warning: RenderTextInvalidConstructor(...): No `render` method found on the returned component instance: ' + | ||
'did you accidentally return an object from the constructor?', | ||
); | ||
}); | ||
|
||
it('should return error if render is not defined', () => { | ||
spyOn(console, 'error'); | ||
class RenderTestUndefinedRender extends React.Component {} | ||
|
||
expect(function() { | ||
ReactTestUtils.renderIntoDocument(<RenderTestUndefinedRender />); | ||
}).toThrow(); | ||
|
||
const error = console.error.calls.mostRecent().args[0]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same feedback |
||
|
||
expectDev(error).toBe( | ||
'Warning: RenderTestUndefinedRender(...): No `render` method found on the returned ' + | ||
'component instance: you may have forgotten to define `render`.', | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also assert we only emit one warning. Like other tests do by asserting on count.