Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor error message #11395

Merged
merged 9 commits into from
Nov 1, 2017
+58 −6
Merged

Constructor error message #11395

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ef3e10
Constructor test and fix complete
Oct 28, 2017
1034a19
Linters and prettier run
Oct 28, 2017
03dc163
Remove unnecessary checks
Oct 29, 2017
e9a0574
Update error message
Oct 29, 2017
51c5c71
Updat unit test
Oct 29, 2017
186062f
prettier
Oct 29, 2017
d739f86
Tweak the check to be more specific
gaearon Oct 31, 2017
0593cce
Move tests to ReactCompositeComponent-test
Nov 1, 2017
884e1b4
add error call count and remove line
Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions packages/react-reconciler/src/ReactFiberClassComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,21 +202,24 @@ module.exports = function(
const name = getComponentName(workInProgress);
const renderPresent = instance.render;

if (type.prototype && type.prototype.render !== undefined) {
warning(
renderPresent,
'%s(...): No `render` method found on the returned component ' +
'instance: is the `constructor` defined well?',
name,
);
} else {
warning(
renderPresent,
'%s(...): No `render` method found on the returned component ' +
'instance: you may have forgotten to define `render`.',
name,
);
if (!renderPresent) {
if (type.prototype && type.prototype.render !== undefined) {
warning(
false,
'%s(...): No `render` method found on the returned component ' +
'instance: is the `constructor` defined well?',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be explicit: "did you accidentally return an object from the constructor"

name,
);
} else {
warning(
false,
'%s(...): No `render` method found on the returned component ' +
'instance: you may have forgotten to define `render`.',
name,
);
}
}

const noGetInitialStateOnES6 =
!instance.getInitialState ||
instance.getInitialState.isReactClassApproved ||
Expand Down