-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event plugins to addons #1170
Conversation
Aw, we lost ABC order |
Anything else need to be done here @petehunt? |
Just did a custom build with these changes and setup a demo but the |
Try adding React.initializeTouchEvents(true) before any of your app code, if you don't have it already. |
No that doesn't seem to work either, see updated test case. |
The updated test case works for me in Mobile Safari on an iPhone 5S & in an emulator. |
👍 I would love to see this merged |
Nah. Let's hold off because supporting this is going to suck. We should figure something out for 1.0, so we can come back around to it then. |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
Please don't add any more "+1" comments. If you don't have anything constructive, don't comment at all. |
@zpao is there a discussion happening around this somewhere? Your last comment was:
|
No, not that I know of. |
So what's the status of it do you think? |
@zpao So this issue, along with #436 are both referenced from https://github.com/zilverline/react-tap-event-plugin – where it says "When Facebook solves #436 and #1170, this repo will disappear". And http://react-components.com/component/material-ui#react-tap-event-plugin where it says "This dependency is temporary and will go away once react v1.0 is released" I believe that's why there's still interest in this issue/PR – really I think everyone's just interested in what the story is for tap events for React. So is there anywhere better to follow the status of this in React, or is this PR (or #436) the best place? |
Let's go with #436. |
Cool, thanks @spicyj ! |
+1 |
1 similar comment
+1 |
I did this in the most API-constrained way possible. Will write docs.