Rudimentary tests for not covered entry points #11835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gaearon , this is the follow up PR for #11750 , changes are
I've also searched the codebase for entry points not covered in tests.
A question regarding the Thanks. |
gaearon
reviewed
Dec 12, 2017
| ) | ||
| .getInstance(); | ||
| expect(wedgeInstance._degreesToRadians(0)).toBe(0); | ||
| expect(wedgeInstance._degreesToRadians(180)).toBe(3.141592653589793); |
There was a problem hiding this comment.
I don’t think we should be calling internal functions. Just using props is enough.
There was a problem hiding this comment.
ok, these tests are removed.
Can't find a good way to test the math generating path, all other props are covered in snapshot tests.
Please let me know if anything's missing.
|
Thanks! |
yenshih
pushed a commit
to yenshih/react
that referenced
this pull request
Jan 6, 2018
* Add basic snapshot tests to ReactART components (Circle, Rectangle, Wedge) * More tests on Circle, Rectangle, Wedge * linc warning fixes * - remove tests to Wedge component internal function * More test on Wedge component, update snapshots
This was referenced Dec 18, 2020
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for ReactART Circle, Rectangle, Wedge components.