Work around IE/Edge bug when rendering inputs in separate windows via portals

[M-ZubairAhmed]

Contributing checklist

• Fork the repository and create your branch from master.
• Run yarn in the repository root.
• If you've fixed a bug or added code that should be tested, add tests!
• Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
• Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
• If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
• Format your code with prettier (yarn prettier).
• Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
• Run the Flow typechecks (yarn flow).
• If you haven't already, complete the CLA.

Problem :

• Issue Error Rendering Inputs in Separate Window using Portals #11768
• Input element in a portal was throwing error only when tested on
  • IE 11
  • Edge 15
  • Edge 14
• Sample jsfiddle https://github.com/kgorgi/react-popout-bug

Solution:

• Moved enumerable descriptor to another defineProperty of same node object.
• there are no side effects to this as

The Object.defineProperty() method defines a new property directly on an object, or modifies an existing property on an object, and returns the object.

• This seems to solve the problem for the browsers mentioned above.

[M-ZubairAhmed]

friendly ping :-)

[gaearon]

OK, this seems fine to me. Thanks!

[Ganesan-rivet]

It is not fixed. In Sample code, change the breakPopout from "false" to "true" (App.js) to display the input control in pop-out window and see the same error 'enumerable' attribute on the property descriptor cannot be set to 'true' on this object.

[gaearon]

@ganesane Thanks for reporting! This makes sense to me (I thought we were hitting some browser engine but but seems like it's either intentional or a DOM bug.) Do you want to look at how this can actually be fixed?

[ianschmitz]

I had tested this a few weeks ago using an alpha version of react/react-dom and it was working using the sample repo. @ganesane are you sure you had the correct 16.3 versions of react/react-dom?

[Ganesan-rivet]

with 16.3.0 versions of react/react-dom. It works fine. Thank you.

[gaearon]

Sounds good, I'll add a note to changelog then. Thanks for double-checking.