Handle nested Fragments in toTree (#12106) #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
approved these changes
Jan 27, 2018
|
This was not a sufficient fix. Please see #12154. |
|
Woops 😬 |
|
I'm feeling worse about this than I probably should. |
|
@maciej-ka don't feel bad at all! This was a great start and it was my responsibility to review and help you. This is solely my fault, and we really appreciate the contribution 🙂 |
|
Yeah this was a comment for @aweary 😛 Didn't mean to make you feel bad, thank you for helping! This is kind of a thorny issue and the code is not easiest to follow. |
This was referenced Mar 30, 2018
This was referenced Apr 2, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12106