Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nested Fragments in toTree (#12106) #12107

Merged

Conversation

maciej-ka
Copy link
Contributor

@maciej-ka maciej-ka commented Jan 27, 2018

Resolves #12106

@aweary aweary merged commit ef8d6d9 into facebook:master Jan 27, 2018
@gaearon
Copy link
Collaborator

gaearon commented Feb 5, 2018

This was not a sufficient fix. Please see #12154.

@maciej-ka maciej-ka deleted the handle-nested-fragments-in-to-tree branch February 5, 2018 12:16
@aweary
Copy link
Contributor

aweary commented Feb 5, 2018

Woops 😬

@maciej-ka
Copy link
Contributor Author

I'm feeling worse about this than I probably should.

@aweary
Copy link
Contributor

aweary commented Feb 5, 2018

@maciej-ka don't feel bad at all! This was a great start and it was my responsibility to review and help you. This is solely my fault, and we really appreciate the contribution 🙂

@gaearon
Copy link
Collaborator

gaearon commented Feb 5, 2018

Yeah this was a comment for @aweary 😛 Didn't mean to make you feel bad, thank you for helping! This is kind of a thorny issue and the code is not easiest to follow.

This was referenced Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants