Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setState() in componentDidMount() should flush synchronously even with createBatch() #12466

Merged
merged 6 commits into from
Mar 29, 2018
Merged

setState() in componentDidMount() should flush synchronously even with createBatch() #12466

merged 6 commits into from
Mar 29, 2018

Commits on Mar 27, 2018

  1. Add a failing test for setState in cDM during batch.commit()

    @gaearon
    gaearon committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    b796908 View commit details
    Browse the repository at this point in the history

  2. Copy pasta

    @gaearon
    gaearon authored Mar 27, 2018
    Configuration menu
    Copy the full SHA
    835d693 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Flush all follow-up Sync work on the committed batch

    @gaearon
    gaearon committed Mar 28, 2018
    2 Configuration menu
    Copy the full SHA
    7e3a38b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Nit: Use performSyncWork 

    Call performSyncWork right after flushing the batch. Does effectively
the same thing by reusing the existing function.

Also added some comments.
    @acdlite
    acdlite committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    41d88c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into maybe-fail

    @acdlite
    acdlite committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    5026b9f View commit details
    Browse the repository at this point in the history

  3. Delete accidentally duplicated test

    @acdlite
    acdlite committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    cf89ddc View commit details
    Browse the repository at this point in the history