Set owner correctly inside forwardRef and context consumer

[sophiebits]

Previously, _owner would be null if you create an element inside forwardRef or inside a context consumer. This is used by ReactNativeFiberInspector when traversing the hierarchy and also to give more info in some warning texts. This also means you'll now correctly get a warning if you call setState inside one of these.

Test Plan: Tim tried it in the RN inspector.

[sebmarkbage]

Does the debug thing need to be wrapped in DEV?

[sophiebits]

Yeah, you're right.

[pull-bot]

Details of bundled changes.

Comparing: a9abd27...e8394da

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.development.js	+0.1%	0.0%	614.9 KB	615.29 KB	142.2 KB	142.21 KB	UMD_DEV
react-dom.development.js	+0.1%	0.0%	599.28 KB	599.67 KB	138.05 KB	138.06 KB	NODE_DEV
ReactDOM-dev.js	+0.1%	0.0%	623.75 KB	624.14 KB	140.84 KB	140.86 KB	FB_WWW_DEV

react-art

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-art.development.js	+0.1%	0.0%	417.84 KB	418.23 KB	91.16 KB	91.17 KB	UMD_DEV
react-art.development.js	+0.1%	0.0%	343.67 KB	344.07 KB	72.49 KB	72.5 KB	NODE_DEV
ReactART-dev.js	+0.1%	0.0%	351.97 KB	352.36 KB	72.08 KB	72.11 KB	FB_WWW_DEV

react-test-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-test-renderer.development.js	+0.1%	0.0%	348.71 KB	349.1 KB	73.38 KB	73.39 KB	UMD_DEV
react-test-renderer.development.js	+0.1%	0.0%	339.54 KB	339.93 KB	70.67 KB	70.68 KB	NODE_DEV
ReactTestRenderer-dev.js	+0.1%	0.0%	348.07 KB	348.46 KB	70.31 KB	70.34 KB	FB_WWW_DEV

react-reconciler

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-reconciler.development.js	+0.1%	0.0%	319.89 KB	320.28 KB	66.12 KB	66.13 KB	NODE_DEV
react-reconciler-persistent.development.js	+0.1%	0.0%	319.22 KB	319.61 KB	65.88 KB	65.89 KB	NODE_DEV

react-native-renderer

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
ReactNativeRenderer-dev.js	+0.1%	0.0%	459.69 KB	460.08 KB	98.35 KB	98.37 KB	RN_FB_DEV
ReactNativeRenderer-dev.js	+0.1%	0.0%	459.44 KB	459.83 KB	98.29 KB	98.31 KB	RN_OSS_DEV
ReactFabric-dev.js	+0.1%	0.0%	442.1 KB	442.49 KB	93.95 KB	93.96 KB	RN_FB_DEV
ReactFabric-dev.js	+0.1%	0.0%	442.13 KB	442.52 KB	93.96 KB	93.98 KB	RN_OSS_DEV

Generated by 🚫 dangerJS

[WOLVIE97]

These changes appear to be appropriately amended...

[WOLVIE97]

looks good, lets try it out...

[yungsters]

Awesome. Thanks for fixing this so quickly.

[sebmarkbage]

This doesn't look right. We shouldn't set current owner, which is runtime behavior, only in DEV. This could mess up certain new features in prod for example.

[sebmarkbage]

We were supposed to use the debug frame thing for DEV warnings instead of owner so that we didn't have to do this. Perhaps the fix is to change how the context warning works so that it doesn't rely on current owner? @acdlite

[sophiebits]

oh hm. for functional and indeterminate components it looks DEV-only:

react/packages/react-reconciler/src/ReactFiberBeginWork.js

Lines 260 to 344 in e8394da

	ReactCurrentOwner.current = workInProgress;
	ReactDebugCurrentFiber.setCurrentPhase('render');
	nextChildren = fn(nextProps, context);
	ReactDebugCurrentFiber.setCurrentPhase(null);
	} else {
	nextChildren = fn(nextProps, context);
	}
	// React DevTools reads this flag.
	workInProgress.effectTag |= PerformedWork;
	reconcileChildren(current, workInProgress, nextChildren);
	memoizeProps(workInProgress, nextProps);
	return workInProgress.child;
	}
	function updateClassComponent(
	current: Fiber | null,
	workInProgress: Fiber,
	renderExpirationTime: ExpirationTime,
	) {
	// Push context providers early to prevent context stack mismatches.
	// During mounting we don't know the child context yet as the instance doesn't exist.
	// We will invalidate the child context in finishClassComponent() right after rendering.
	const hasContext = pushLegacyContextProvider(workInProgress);
	let shouldUpdate;
	if (current === null) {
	if (workInProgress.stateNode === null) {
	// In the initial pass we might need to construct the instance.
	constructClassInstance(
	workInProgress,
	workInProgress.pendingProps,
	renderExpirationTime,
	);
	mountClassInstance(workInProgress, renderExpirationTime);
	shouldUpdate = true;
	} else {
	// In a resume, we'll already have an instance we can reuse.
	shouldUpdate = resumeMountClassInstance(
	workInProgress,
	renderExpirationTime,
	);
	}
	} else {
	shouldUpdate = updateClassInstance(
	current,
	workInProgress,
	renderExpirationTime,
	);
	}
	return finishClassComponent(
	current,
	workInProgress,
	shouldUpdate,
	hasContext,
	renderExpirationTime,
	);
	}
	function finishClassComponent(
	current: Fiber | null,
	workInProgress: Fiber,
	shouldUpdate: boolean,
	hasContext: boolean,
	renderExpirationTime: ExpirationTime,
	) {
	// Refs should update even if shouldComponentUpdate returns false
	markRef(current, workInProgress);
	const didCaptureError =
	(workInProgress.effectTag & DidCapture) !== NoEffect;
	if (!shouldUpdate && !didCaptureError) {
	// Context providers should defer to sCU for rendering
	if (hasContext) {
	invalidateContextProvider(workInProgress, false);
	}
	return bailoutOnAlreadyFinishedWork(current, workInProgress);
	}
	const ctor = workInProgress.type;
	const instance = workInProgress.stateNode;
	// Rerender
	ReactCurrentOwner.current = workInProgress;

I guess that's an oversight?

[gaearon]

I think at the time this was intentional because we didn't separate those concepts, and didn't want to have the overhead of setting a property in PROD when it doesn't end up being used (functional components can't be ref owners which was the only runtime behavior of this feature).

[sebmarkbage]

We just have to be better at following through when we change strategies like introducing debug frame.