Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwinding starting with a wrong Fiber on error in the complete phase #13237

Merged
merged 4 commits into from
Jul 19, 2018

Commits on Jul 18, 2018

  1. Add a repro case for profiler unwinding

    This currently fails the tests due to an unexpected warning.
    gaearon committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    4b42af1 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Configuration menu
    Copy the full SHA
    7ca7cc9 View commit details
    Browse the repository at this point in the history
  2. Simplify the first test case

    gaearon committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    6815275 View commit details
    Browse the repository at this point in the history
  3. Update nextUnitOfWork inside completeUnitOfWork()

    The bug was caused by a structure like this:
    
        </Provider>
      </div>
    </errorInCompletePhase>
    
    We forgot to update nextUnitOfWork so it was still pointing at Provider when errorInCompletePhase threw. As a result, we would try to unwind from Provider (rather than from errorInCompletePhase), and thus pop the Provider twice.
    gaearon committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    9422702 View commit details
    Browse the repository at this point in the history