Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not for Merge] Investigate CI failures on Symbol/Function warning PR #13453

Closed
wants to merge 18 commits into from
Closed

[Not for Merge] Investigate CI failures on Symbol/Function warning PR #13453

wants to merge 18 commits into from

Commits on Aug 16, 2018

  1. Update attribute-table

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    c21d4d6 View commit details
    Browse the repository at this point in the history

  2. Add to-string protection to SSR

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    50e3c04 View commit details
    Browse the repository at this point in the history

  3. Add validation step to inputs

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    3508621 View commit details
    Browse the repository at this point in the history

  4. Only validate textarea value prop

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    a0c56ff View commit details
    Browse the repository at this point in the history

  5. Make diff less noisy

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    3019cac View commit details
    Browse the repository at this point in the history

  6. Properly handle true/false and NaN

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    bce41fe View commit details
    Browse the repository at this point in the history

  7. Simplify validation by doing it ahead of time

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    c886074 View commit details
    Browse the repository at this point in the history

  8. Revert toStringValue change

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    a038541 View commit details
    Browse the repository at this point in the history

  9. Tweak toStringValue comment

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    b4b0797 View commit details
    Browse the repository at this point in the history

  10. defaultValue and defaultChecked are no longer reserved words

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    9989dd4 View commit details
    Browse the repository at this point in the history

  11. Use correct type for defaultValue and defaultChecked

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    9c62214 View commit details
    Browse the repository at this point in the history

  12. Add test coverage and fixes for mixed type selection on options

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    1 Configuration menu
    Copy the full SHA
    7619d04 View commit details
    Browse the repository at this point in the history

  13. Make the diff less noisy

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    375fcae View commit details
    Browse the repository at this point in the history

  14. Improve comment about backwards compatibility with defaultValue

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    760262d View commit details
    Browse the repository at this point in the history

  15. Grammar matters

    @nhunzaker
    nhunzaker committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    ba124bf View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Align defaultValue and defaultChecked with value and checked

    @nhunzaker
    nhunzaker committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    d47dab7 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Remove new textarea symbol/function tests

    @nhunzaker
    nhunzaker committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    edf5a4a View commit details
    Browse the repository at this point in the history

  2. Disable symbol/function select tests

    @nhunzaker
    nhunzaker committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    7fac775 View commit details
    Browse the repository at this point in the history