Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit: Fix updateWrapper causing re-render textarea, even though their data #13643

Merged
merged 3 commits into from
Sep 14, 2018

Conversation

nhunzaker
Copy link
Contributor

Looks like I didn't do the rebase on #12080 correctly. This is a resubmission of resubmission of #12080. Sorry @joelbarbosa :(

Fixes: #12072

@nhunzaker nhunzaker changed the title Joelbarbosa textarea fix Resubmit: ix updateWrapper causing re-render textarea, even though their data Sep 14, 2018
@nhunzaker nhunzaker changed the title Resubmit: ix updateWrapper causing re-render textarea, even though their data Resubmit: Fix updateWrapper causing re-render textarea, even though their data Sep 14, 2018
@nhunzaker nhunzaker requested a review from aweary September 14, 2018 00:52
@sizebot
Copy link

sizebot commented Sep 14, 2018

Details of bundled changes.

Comparing: b488a5d...55a5686

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@nhunzaker
Copy link
Contributor Author

I have tested this across all browsers in our matrix:

Browser Versions
Chrome - Desktop 49*, Latest
Chrome - Android Latest
Firefox Desktop ESR†, Latest
Internet Explorer 9, 10, 11
Microsoft Edge 14, Latest
Safari - Desktop 7, Latest
Safari - iOS 7, Latest

@nhunzaker nhunzaker merged commit d92114b into facebook:master Sep 14, 2018
@nhunzaker
Copy link
Contributor Author

Thanks!

@aweary
Copy link
Contributor

aweary commented Sep 14, 2018

Thank you for testing 😄

gaearon added a commit that referenced this pull request Sep 17, 2018
Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
…heir data (facebook#13643)

* fix updateWrapper causing re-render textarea, even though their data has not changed

* fix updateWrapper causing re-render textarea, even though their data, prettier-all

* minor changes to updateWrapper, add test
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
…heir data (facebook#13643)

* fix updateWrapper causing re-render textarea, even though their data has not changed

* fix updateWrapper causing re-render textarea, even though their data, prettier-all

* minor changes to updateWrapper, add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants