-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resubmit: Fix updateWrapper causing re-render textarea, even though their data #13643
Merged
nhunzaker
merged 3 commits into
facebook:master
from
nhunzaker:joelbarbosa-textarea-fix
Sep 14, 2018
Merged
Resubmit: Fix updateWrapper causing re-render textarea, even though their data #13643
nhunzaker
merged 3 commits into
facebook:master
from
nhunzaker:joelbarbosa-textarea-fix
Sep 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
changed the title
Joelbarbosa textarea fix
Resubmit: ix updateWrapper causing re-render textarea, even though their data
Sep 14, 2018
nhunzaker
changed the title
Resubmit: ix updateWrapper causing re-render textarea, even though their data
Resubmit: Fix updateWrapper causing re-render textarea, even though their data
Sep 14, 2018
Details of bundled changes.Comparing: b488a5d...55a5686 schedule
Generated by 🚫 dangerJS |
I have tested this across all browsers in our matrix:
|
aweary
approved these changes
Sep 14, 2018
Thanks! |
Thank you for testing 😄 |
This was referenced Sep 19, 2018
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
…heir data (facebook#13643) * fix updateWrapper causing re-render textarea, even though their data has not changed * fix updateWrapper causing re-render textarea, even though their data, prettier-all * minor changes to updateWrapper, add test
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…heir data (facebook#13643) * fix updateWrapper causing re-render textarea, even though their data has not changed * fix updateWrapper causing re-render textarea, even though their data, prettier-all * minor changes to updateWrapper, add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I didn't do the rebase on #12080 correctly. This is a resubmission of resubmission of #12080. Sorry @joelbarbosa :(
Fixes: #12072