Rename AsyncMode -> ConcurrentMode #13732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Prettier Fix up More renames
Details of bundled changes.Comparing: d0c0ec9...d02c8b8 react-test-renderer
react-is
scheduler
Generated by 🚫 dangerJS |
gaearon
reviewed
Sep 26, 2018
| @@ -68,8 +68,8 @@ export const StrictMode = REACT_STRICT_MODE_TYPE; | |||
|
|
|||
| export {isValidElementType}; | |||
|
|
|||
| export function isAsyncMode(object: any) { | |||
| return typeOf(object) === REACT_ASYNC_MODE_TYPE; | |||
| export function isConcurrentMode(object: any) { | |||
There was a problem hiding this comment.
Both this and symbol export rename would be a breaking change technically. Unfortunately we forgot the unstable prefix here. Let’s keep both and add a deprecation warning for isAsyncMode.
There was a problem hiding this comment.
I've made the change. Did I do it correctly?
gaearon
reviewed
Sep 26, 2018
packages/react-is/src/ReactIs.js
Outdated
| 'and will be removed in React 17+. Update your code to use ' + | ||
| 'ReactIs.isConcurrentMode() instead. It has the exact same API.', | ||
| ); | ||
| if (!hasWarnedAboutDeprecatedIsAsyncMode) { |
There was a problem hiding this comment.
This should be inside if (__DEV__)
gaearon
approved these changes
Sep 26, 2018
|
Hey @trueadm. This change will require a corresponding change in react-devtools. Are you also going to own that? |
|
@bvaughn Just found the comment. Sure! |
|
Is it the breaking change? |
|
No. Both async and concurrent modes are "unstable_" (e.g. |
acdlite
pushed a commit
to plievone/react
that referenced
this pull request
Oct 5, 2018
* Rename AsyncMode -> ConcurrentMode
Merged
This was referenced Oct 24, 2018
This was referenced Oct 24, 2018
ljharb
added a commit
to ljharb/react
that referenced
this pull request
Oct 24, 2018
- Partial revert of facebook#13732 - Fixes facebook#13958.
ljharb
added a commit
to ljharb/react
that referenced
this pull request
Oct 25, 2018
- Partial revert of facebook#13732 - Fixes facebook#13958.
|
Are there any doc about the usage of this ConcurrentMode Mode? |
|
No — it's unstable. We only document stable features. |
This was referenced Oct 29, 2018
gaearon
pushed a commit
that referenced
this pull request
Oct 31, 2018
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Rename AsyncMode -> ConcurrentMode
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…k#13959) - Partial revert of facebook#13732 - Fixes facebook#13958.
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Rename AsyncMode -> ConcurrentMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
AsyncModetoConcurrentMode. Specifically:Reactexportsunstable_ConcurrentModenow rather thanunstable_AsyncMode.ReactTestRendernow takesunstable_isConcurrentas an option rather thanunstable_isAsync.isAsynchave been renamed toisConcurrentto reflect the naming changes.REACT_ASYNC_MODE_TYPEhas been renamed toREACT_CONCURRENT_MODE_TYPE.react-isnow exportsisConcurrentMode, renamed fromisAsyncMode.