Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lint against Hooks after conditional throw #14040

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Don't lint against Hooks after conditional throw #14040

merged 1 commit into from
Oct 31, 2018

Commits on Oct 31, 2018

  1. Don't lint against Hooks after conditional throw 

    Seems like this should be OK. Fixes facebook#14038.

Now when tracking paths, we completely ignore segments that end in a throw. In https://eslint.org/docs/developer-guide/code-path-analysis I don't see a way to detect throws other than manually tracking them, so that's what I've done.
    @sophiebits
    sophiebits committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    fcd4703 View commit details
    Browse the repository at this point in the history