Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for stuck Suspense fallback #14079

Closed
wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 2, 2018

Another issue that was discovered in #14073 (comment) (although this one is specific to concurrent mode). This just looks like a bug.

Setting second child's ms lower does not reproduce it.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 2, 2018

Might be the same problem as #14013? Don't know.

@sizebot
Copy link

sizebot commented Nov 2, 2018

Details of bundled changes.

Comparing: c84b9bf...06433bb

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@sophiebits
Copy link
Collaborator

What is supposed to set .alreadyCaptured to false? It seems like once it gets set to true, the only thing that can set it back to false (and thus trigger a retry of the primary content) is the commit phase, which never runs for a suspended update. Not sure if I'm missing some part of the model in my head.

cc @acdlite

@sophiebits
Copy link
Collaborator

Might be the same problem as #14013? Don't know.

Looks like it. Seems like once something pings once in concurrent mode, further pings end up being no-ops.

@acdlite
Copy link
Collaborator

acdlite commented Nov 4, 2018

Fixed by #14083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants