Warn about conflicting style values during updates #14181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bvaughn This is probably one of the only bugs that both you (#8689) and I (#6348 (comment)) have both run into. 😂 Hope this warning helps. |
sophiebits
force-pushed
the
css-shorthand-warn
branch
from
baa89c8
to
84bcf8c
Compare
Details of bundled changes.Comparing: 2dd4ba1...399ac96 react-dom
Generated by 🚫 dangerJS |
bvaughn
reviewed
Nov 9, 2018
| * {font: 'foo', fontVariant: 'bar'} -> {font: 'foo'} | ||
| * becomes .style.fontVariant = '' | ||
| */ | ||
| export function validateShorthandPropertyCollisionInDev( |
There was a problem hiding this comment.
Seems like this could get noisy if we don't do any kind of de-duping. I wonder if this is something you considered and ruled out?
Guess de-duping would have a small impact on tests too.
There was a problem hiding this comment.
I thought about it but I don't think this will be very common, it is a bad bug, and it is pretty easy to fix – so I think it's OK not to.
|
|
||
| expect(() => | ||
| ReactDOM.render( | ||
| <div style={{font: 'qux', fontStyle: 'baz'}} />, |
There was a problem hiding this comment.
Ugh, this is subtle. Had to read these tests a couple times. Nice to have a warning for it.
This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.
We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn.
Fixes facebook#6348.
sophiebits
force-pushed
the
css-shorthand-warn
branch
from
84bcf8c
to
399ac96
Compare
bvaughn
approved these changes
Nov 9, 2018
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Nov 10, 2018
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
sophiebits
added a commit
that referenced
this pull request
Nov 10, 2018
I figured out a simpler way to do #14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
Merged
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Nov 15, 2018
Disables the recently introduced (facebook#14181) warning for shorthand CSS property collisions by wrapping in a feature flag. Let's hold off shipping this until at least the next minor.
acdlite
added a commit
that referenced
this pull request
Nov 15, 2018
Disables the recently introduced (#14181) warning for shorthand CSS property collisions by wrapping in a feature flag. Let's hold off shipping this until at least the next minor.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.
We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn.
Fixes facebook#6348.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…ok#14245) Disables the recently introduced (facebook#14181) warning for shorthand CSS property collisions by wrapping in a feature flag. Let's hold off shipping this until at least the next minor.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.
We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn.
Fixes facebook#6348.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…ok#14245) Disables the recently introduced (facebook#14181) warning for shorthand CSS property collisions by wrapping in a feature flag. Let's hold off shipping this until at least the next minor.
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Feb 9, 2020
Originally added in facebook#14181; disabled in facebook#14245. Intention was to enable it in React 16.7 but we forgot.
threepointone
pushed a commit
that referenced
this pull request
Feb 10, 2020
Merged
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.
We still allow rendering
{background, backgroundSize}with unchanging values, for example. But once you remove either one or changebackground(without changingbackgroundSizeat the same time), that's bad news. So we warn.Fixes #6348.