Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give canUseDOM with a possibility to be a constant #14194

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

gfx
Copy link
Contributor

@gfx gfx commented Nov 12, 2018

https://webpack.js.org/plugins/define-plugin/

Webpack's DefinePlugin has the ability to replace typeof expr to a constant in compile-time, which should lead to better dead-code-elimination.

https://webpack.js.org/plugins/define-plugin/

Webpack's DefinePlugin has the ability to replace `typeof expr` to a constant in compile-time, which should lead to better dead-code-elimination.
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I actually wrote this code many many years ago at FB. This makes sense to me! Thanks for your PR.

@cpojer cpojer merged commit 1eb2b89 into facebook:master Apr 25, 2019
@gfx gfx deleted the patch-1 branch June 12, 2019 01:08
@gfx
Copy link
Contributor Author

gfx commented Jun 12, 2019

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants